Upgrade DataFusion to 40.0.0 #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Jul 18, 2024
| @@ -313,9 +310,9 @@ mod test { | |||
| "select orderkey + orderkey from test.test.orders", | |||
| "select orderkey from test.test.orders where orders.totalprice > 10", | |||
| "select orders.orderkey from test.test.orders left join test.test.customer on (orders.custkey = customer.custkey) where orders.totalprice > 10", | |||
| "select orderkey, sum(totalprice) from test.test.orders group by 1", | |||
| "select orderkey, min(totalprice) from test.test.orders group by 1", | |||
There was a problem hiding this comment.
The sum function is moved to datafusion-function-aggregate after 40.0.0. The aggregate function crate won't be registered for the custom context provider by default. We should use SessionContext in
I will do it in another PR.
grieve54706
approved these changes
Jul 18, 2024
grieve54706
pushed a commit
that referenced
this pull request
Dec 13, 2024
* upgrade to 40.0.0 and fix the api * fix the test cases * update lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description