Skip to content

Fix the format of TableReference #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2024
Merged

Fix the format of TableReference #678

merged 3 commits into from
Jul 18, 2024

Conversation

goldmedal
Copy link
Contributor

close #591

@goldmedal goldmedal marked this pull request as ready for review July 18, 2024 06:30
@goldmedal goldmedal requested a review from grieve54706 July 18, 2024 06:30
grieve54706
grieve54706 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal

@grieve54706 grieve54706 merged commit d320c22 into Canner:main Jul 18, 2024
10 checks passed
@goldmedal goldmedal deleted the feature/591-fix-table-ref-v2 branch July 18, 2024 06:53
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
@goldmedal
Fix the format of TableReference (#678)
3c2fdd0 
* support correct table reference format

* fix py tests

* fix the property name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the format of TableReference
2 participants
@goldmedal @grieve54706