Skip to content

Fix the format of TableReference #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goldmedal opened this issue Jun 3, 2024 · 0 comments · Fixed by #678
Closed

Fix the format of TableReference #591

goldmedal opened this issue Jun 3, 2024 · 0 comments · Fixed by #678
Assignees
@goldmedal
Labels
enhancement New feature or request modeling-rs

Comments

@goldmedal
Copy link
Contributor

Description

The table reference of a model is a object but it's a string in rust version now.

{
   "catalog": "c1",
   "schema": "s1",
   "table": "t1"
}

https://github.com/goldmedal/wren-engine/blob/930a8d8bf9e944d4f127b0bad2bab67606df4359/wren-modeling-rs/src/mdl/manifest.rs#L29

The catalog and schema are optional but table should be required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goldmedal goldmedal

Labels
enhancement New feature or request modeling-rs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the format of TableReference goldmedal/wren-engine
1 participant
@goldmedal