chore(ibis-bq): add timestamp function for BigQuery

[goldmedal]

• Add TIMESTAMP function in the BigQuery function list.
• Fix the bigquery test
• Fix the tool script

Summary by CodeRabbit

• Tests

  • Updated test expectations for the number of functions returned in BigQuery connector tests.
  • Adjusted the order of expected query result values in test assertions.
  • Simplified error response assertions for invalid manifest strings in tests.

• Chores

  • Modified local query tool to dynamically append the data source name to the function list file path.

[coderabbitai]

Walkthrough

The changes update test assertions and a utility script related to BigQuery connector functionality. In the BigQuery function list test, the expected number of functions is incremented by one. In the BigQuery query test, the expected order of returned query results is changed, and a strict error message check for invalid manifests is removed. In the query local run tool, the session context initialization now appends the data source name with a .csv extension to the function list path, altering how the function list file is specified.

Changes

File(s)	Change Summary
ibis-server/tests/routers/v3/connector/bigquery/test_functions.py	Updated test to expect one additional function in the returned list.
ibis-server/tests/routers/v3/connector/bigquery/test_query.py	Reordered expected query result values and removed strict error message assertion for invalid input.
ibis-server/tools/query_local_run.py	Modified session context to append data source name with .csv to the function list path.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant query_local_run.py
    participant SessionContext

    User->>query_local_run.py: Run query with data_source and function_list_path
    query_local_run.py->>SessionContext: Initialize with function_list_path + data_source + ".csv"
    SessionContext-->>query_local_run.py: Context ready with specific function list
    query_local_run.py-->>User: Return results

Loading

Possibly related PRs

• chore: fix BigQuery v3 test cases #1031: Modifies the same test assertion for function count, but in the opposite direction.
• fix(core): simplify the available function lists #1131: Adjusts function list details and counts in tests, closely related to the updated expected function count.

Suggested labels

ibis, python

Suggested reviewers

• wwwy3y3

Poem

A hop, a skip, a function more,
BigQuery tests now even the score.
CSV paths with names that grow,
Query results in a brand new row.
Rabbits cheer with every run—
More functions found, more data fun!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab46611 and eec3f7c.

⛔ Files ignored due to path filters (1)

• ibis-server/resources/function_list/bigquery.csv is excluded by !**/*.csv

📒 Files selected for processing (3)

• ibis-server/tests/routers/v3/connector/bigquery/test_functions.py (1 hunks)
• ibis-server/tests/routers/v3/connector/bigquery/test_query.py (1 hunks)
• ibis-server/tools/query_local_run.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: ci

🔇 Additional comments (4)

ibis-server/tools/query_local_run.py (1)

61-61: The session context initialization now correctly uses a data source-specific function list file.

This change dynamically constructs the path to a data source-specific function list CSV file, which aligns with the PR's goal of adding the TIMESTAMP function for BigQuery. This approach allows for better separation of functions available for different data sources.

ibis-server/tests/routers/v3/connector/bigquery/test_functions.py (1)

48-48: Function count incremented to account for the new TIMESTAMP function.

The expected count of functions has been increased by one (from 34 to 35), which correctly reflects the addition of the TIMESTAMP function to the BigQuery functions list as mentioned in the PR objectives.

ibis-server/tests/routers/v3/connector/bigquery/test_query.py (2)

80-91: Updated test assertion for query result order.

The test assertion has been updated to reflect the correct ordering of fields in the query results. This change is consistent with the addition of the TIMESTAMP function and ensures that tests remain accurate.

---

143-144: Simplified error validation for invalid manifest string.

The test now only verifies the status code (422) for an invalid manifest string without asserting the exact error message. This makes the test more resilient to minor changes in error message formatting.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[goldmedal]

BigQuery test are passed in the local.

poetry run pytest -m 'bigquery'
============================================================================================================== test session starts ==============================================================================================================
platform darwin -- Python 3.11.11, pytest-8.3.5, pluggy-1.5.0
rootdir: /Users/jax/git/wren-engine/ibis-server
configfile: pyproject.toml
plugins: anyio-4.9.0
collected 310 items / 278 deselected / 32 selected                                                                                                                                                                                              

tests/routers/v2/connector/test_bigquery.py ....................                                                                                                                                                                          [ 62%]
tests/routers/v3/connector/bigquery/test_functions.py ...                                                                                                                                                                                 [ 71%]
tests/routers/v3/connector/bigquery/test_query.py .........    

[douenergy]

Thanks @goldmedal