chore: fix BigQuery v3 test cases #1031
Conversation
WalkthroughThe pull request contains modifications to two test files in the BigQuery connector section of the ibis-server project. The changes involve adjusting test assertions in two different test functions: one modifying the expected function count and another changing the data type of a price value from numeric to string. These updates appear to be fine-tuning test expectations to match current implementation details. Changes
Suggested labels
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ibis-server/tests/routers/v3/connector/bigquery/test_functions.py(1 hunks)ibis-server/tests/routers/v3/connector/bigquery/test_query.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: ci
🔇 Additional comments (1)
ibis-server/tests/routers/v3/connector/bigquery/test_query.py (1)
90-90: Review data type consistencyThere's a potential inconsistency in the test:
- The test value is now a string
"356711.63"- The dtype assertion still expects
"float64"- The manifest defines the column as
"double"Please verify if this change aligns with BigQuery's actual behavior for numeric value serialization.
Run this script to verify BigQuery's behavior:
✅ Verification successful
String representation is compatible with float64 type
The string representation
"356711.63"is consistent with BigQuery's serialization behavior while maintaining thefloat64type system. This is verified by:
- BigQuery connector uses "double" in manifest (schema) definitions
- All connectors consistently handle numeric types as float64 in pandas
- String serialization doesn't affect the underlying type system
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for similar numeric value handling in other test files # Search for numeric value assertions in test files echo "Checking numeric value handling in other test files:" rg -A 2 'o_totalprice.*float|double' tests/Length of output: 207
Script:
#!/bin/bash # First, find the exact path of the test file fd "test_query.py" # Then examine the content focusing on dtype assertions and numeric handling echo "=== Checking dtype assertions and numeric handling ===" rg -A 3 "dtype.*float|o_totalprice.*float|double" $(fd "test_query.py") # Look for manifest definitions echo "=== Checking manifest definitions ===" fd "manifest.json" | xargs rg "o_totalprice"Length of output: 10633
Changed
Summary by CodeRabbit
o_totalpriceas a string value instead of a float