Skip to content

DM-11609 fix File Upload out of focus issue while editing the url input field #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2017
Merged

DM-11609 fix File Upload out of focus issue while editing the url input field #456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e928d3f
DM-11609 fix File Upload out of focus issue while editing the url inp…
Sep 7, 2017
6e6c2a4
DM-11609 remove unneed import.
Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/firefly/js/ui/FileUpload.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ function FileUploadView({fileType, isLoading, label, valid, wrapperStyle, messa

return (
<InputFieldView
key={'upload_'+(new Date().valueOf())}
valid={valid}
visible={true}
message={message}
Expand Down Expand Up @@ -96,11 +95,13 @@ export const FileUpload = fieldGroupConnector(FileUploadView, getProps);


function onUrlChange(ev, store, fireValueChange) {
var value = ev.target.value;
var {valid,message, ...others}= store.validator(value);
const displayValue = ev.target.value;
const {valid,message, ...others}= store.validator(displayValue);
let value;

has(others, 'value') && (value = others.value); // allow the validator to modify the value.. useful in auto-correct.

fireValueChange({ value, message, valid, displayValue: value, analysisResult:''});
fireValueChange({ value, message, valid, displayValue, analysisResult:''});
}

function getProps(params, fireValueChange) {
Expand Down