Skip to content

DM-11609 fix File Upload out of focus issue while editing the url input field #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2017
Merged

DM-11609 fix File Upload out of focus issue while editing the url input field #456

merged 2 commits into from
Sep 8, 2017

Conversation

cwang2016
Copy link
Contributor

This development fixes the URL input field editing problem, losing focus while entering the URL, from Upload tab.

test:
start firefly (localhost:8080/firefly)
select 'Upload'
select 'Upload from URL'
enter URL into the field 'Enter URL of a file'

@cwang2016 cwang2016 self-assigned this Sep 7, 2017
@cwang2016 cwang2016 requested a review from loitly September 7, 2017 17:25
loitly
loitly approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works great.

@cwang2016 cwang2016 merged commit 9d8d148 into dev Sep 8, 2017
@cwang2016 cwang2016 deleted the DM-11609-UploadURL branch September 8, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loitly loitly loitly approved these changes

Assignees

@cwang2016 cwang2016

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwang2016 @loitly