DM-6135: vo search simplified panel #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <ValidationField | ||
| fieldKey={'vourl'} | ||
| /*validator={urlValidator}*/ | ||
| tooltip='Enter the VO cone search URL directly (or use the link below to open external NVO search and find the VO cone search URL)' |
There was a problem hiding this comment.
please check if this tooltip is shown?
There was a problem hiding this comment.
You are right, it doesn't. I will fix that. Need to be in a 'initialState' object to be set properly.
|
review is done. Looks good. |
|
Just one more comment: VO URL field should show validation errors. When search is clicked and the VO URL field is invalid or empty, nothing happens. There should be a red validation error mark just like for empty target. (You can set nullAllowed=false and validator in initial state.) |
now using default parameters in app mode (when no xCol and yCol are present)
DM-6726 Default chart and other optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, review this branch and let me know. VO search panel will be found in the last right-hand tab on the 'Catalog' search dropdown panel and can be tested by using VO URL value as:
http://vizier.u-strasbg.fr/viz-bin/votable/-A?-source=J/A+A/402/549
and 'ngc3293' as target.