Skip to content

DM-6726 Default chart and other optimizations #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2016
Merged

Conversation

tgoldina
Copy link
Contributor

  • Removed chart selection from chart area
  • Dropdown for chart selection (can be omitted if single chart type is used)
  • Populate current values in chart options
  • Support Clear and Reset in chart options
  • For tables, connected to charts, if no default parameters are specified, default chart id XY plot with center columns for catalogs or two first numeric columns for other tables.
  • Label, matching column expression, and unit, matching table model, are default parameters for both app and api now.
  • Cleaned chart API a bit

@cwang2016
Copy link
Contributor

Review is done. Looks good.
Just wondering, for Unit entry (on X Label/Unit/Options), is there an allowed list for the unit? if there is, would that be better to let the user to pick the unit from a list? if there is some design concern, just ignore my sudden thought.

@tgoldina
Copy link
Contributor Author

If left empty, the unit should be set to the unit of the corresponding
column. But we want to give user flexibility to enter whatever he likes,
especially when expressions are involved.

2016-06-28 14:31 GMT-07:00 Cindy Wang [email protected]:

Review is done. Looks good.
Just wondering, for Unit entry (on X Label/Unit/Options), is there an
allowed list for the unit? if there is, would that be better to let the
user to pick the unit from a list? if there is some design concern, just
ignore my sudden thought.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALU3QKaer-0pakxN_f_KkzJZu_LIUhrJks5qQZK2gaJpZM4JAdaS
.

@ejoliet
Copy link
Contributor

ejoliet commented Jun 28, 2016

Expanded mode doesn't work (Chrome and Firefox tested). It shows histogram option instead (?). Should be XY plot in full size i guess. Please check.

 now using default parameters in app mode (when no xCol and yCol are present)
@tgoldina tgoldina merged commit c3b3377 into dev Jun 29, 2016
@tgoldina tgoldina deleted the dm-6726-defaultchart branch July 7, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants