Skip to content

Updated to reflect changes to FilterPanelsByType method #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

jamesramsden-bh
Copy link
Contributor

Issues addressed by this PR

Closes #546

Test files

Changelog

Additional comments

@jamesramsden-bh jamesramsden-bh added the size:S Measured in minutes label Feb 14, 2022
@jamesramsden-bh jamesramsden-bh self-assigned this Feb 14, 2022
@FraserGreenroyd FraserGreenroyd changed the title XML_Toolkit: Updated to reflect changes to FilterPanelsByType method Updated to reflect changes to FilterPanelsByType method Feb 15, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@jamesramsden-bh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@jamesramsden-bh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on IES_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@jamesramsden-bh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on IES_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 7 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FraserGreenroyd FraserGreenroyd added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Feb 15, 2022
@FraserGreenroyd FraserGreenroyd merged commit f7df7e8 into main Feb 15, 2022
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#182-TranslucentShadeElements branch February 15, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S Measured in minutes type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated FilterPanelsByType now requires a list of PanelType
2 participants