-
Notifications
You must be signed in to change notification settings - Fork 1
Translucent panel #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translucent panel #186
Conversation
Co-authored-by: Fraser Greenroyd <[email protected]>
…ithub.com/BHoM/IES_Toolkit into IES_Toolkit-#182-TranslucentShadeElements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the GEM file creation using a GH script and then imported the GEM into IES. The translucent shade component appeared in the correct place and was recognised as translucent by IES straight away. Seems to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing to IES: Pass. Confirmed with @RMildiner that a pushed model opens in IES correctly.
Pulling to IES: Fail. The 'opening' within the shade is offset by a vector of approximately 8m,8m,8m. This issue is not evident when using a non-translucent shade. (Test GEM files for translucent and non-translucent within the zip file attached.)
translucent push and pull tests.zip
Fail from previous comment now fixed. @FraserGreenroyd now ready for review. |
@robinflyman just to let you know, I have provided a |
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against translucent shading sections of testing procedure, LGTM.
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
The check |
The check |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is documentation-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199266217 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199267343 |
@FraserGreenroyd I have now provided a passing check on reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested through on test procedure by others, code reviewed by me, updates required to engine have been implemented and are working happily. Versioning and installer checks are happy, so deploying to alpha for further testing.
Closes #182