Skip to content

Translucent panel #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 15, 2022
Merged

Conversation

robinflyman
Copy link
Contributor

@robinflyman robinflyman commented Jan 27, 2022

Closes #182

@robinflyman robinflyman added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge status:WIP PR in progress and still in draft, not ready for formal review labels Jan 27, 2022
@robinflyman robinflyman self-assigned this Jan 27, 2022
@robinflyman robinflyman requested a review from tg359 as a code owner January 27, 2022 15:39
@robinflyman robinflyman added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge status:WIP PR in progress and still in draft, not ready for formal review labels Feb 7, 2022
RMildiner
RMildiner previously approved these changes Feb 7, 2022
Copy link

@RMildiner RMildiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the GEM file creation using a GH script and then imported the GEM into IES. The translucent shade component appeared in the correct place and was recognised as translucent by IES straight away. Seems to work.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing to IES: Pass. Confirmed with @RMildiner that a pushed model opens in IES correctly.

Pulling to IES: Fail. The 'opening' within the shade is offset by a vector of approximately 8m,8m,8m. This issue is not evident when using a non-translucent shade. (Test GEM files for translucent and non-translucent within the zip file attached.)
translucent push and pull tests.zip

@jamesramsden-bh
Copy link
Contributor

Fail from previous comment now fixed. @FraserGreenroyd now ready for review.
@robinflyman no action needed from you right now.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@robinflyman just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against translucent shading sections of testing procedure, LGTM.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199266217

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199267343

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199266217

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd I have now provided a passing check on reference 5199266217 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 5199267343

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2022

@FraserGreenroyd I have now provided a passing check on reference 5199267343 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested through on test procedure by others, code reviewed by me, updates required to engine have been implemented and are working happily. Versioning and installer checks are happy, so deploying to alpha for further testing.

@FraserGreenroyd FraserGreenroyd merged commit 816c130 into main Feb 15, 2022
@FraserGreenroyd FraserGreenroyd deleted the IES_Toolkit-#182-TranslucentShadeElements branch February 15, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IES_Tookit: Push/Pull Translucent shade elements
4 participants