-
Notifications
You must be signed in to change notification settings - Fork 3
Remove Event adders and removers from versioning test-sets #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Event adders and removers from versioning test-sets #281
Conversation
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check versioning -force |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the list of methods removed.
The versioning check is now passing.
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
…AnalyticsPopupForIncompatibleVersions
@BHoMBot check installer |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
The check |
Issues addressed by this PR
Done in support of BHoM/BHoM_UI#505
Removing event adders and removers from the versioning test sets, as should not be there in the first place.
Methods to not be part of the BHoMMethodList in the first place, which will make sure they dont end up in the testsets going forward. Issue for this raised here:
BHoM/BHoM_Engine#3461
Test files
Botchecks on versioning should be sufficient
Changelog
Additional comments