Skip to content

BHoM_Engine: Exclude SpecialName methods from BhoMMethodList #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Feb 22, 2025

Issues addressed by this PR

Closes #3461

Explude IsSpecialName from being added to the BHoMMethodList. This excludes Proeprty get and sets, from Properties in the engine. Also excludes Add and Remove methods for events.

This relates to these PRs:
BHoM/Versioning_Toolkit#276
BHoM/Versioning_Toolkit#281

Test files

Run the testscript on develop, internalise the results, then re-run on branch and check that the items removed make sense. @pawelbaran quite a few Revit types flagged, so good to make sure you are happy with the removal of them, and that they are not required to be in the BHoMMethod list for anything revit-related (assume not, but want to double check)

Test script on sharepoint

Changelog

Additional comments

This excludes:
 Property.Get and .set
Event.Add and .Remove
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Feb 22, 2025
@IsakNaslundBh IsakNaslundBh self-assigned this Feb 22, 2025
Copy link

bhombot-ci bot commented Feb 25, 2025

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check unit-tests has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check unit-tests has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Feb 25, 2025

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 24, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit f84c5ea into develop Mar 24, 2025
12 checks passed
@pawelbaran pawelbaran deleted the BHoM_Engine-#3461-RemoveEventAndPropertyMethodsFromBHomMethodList branch March 24, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove event adders as well as property getters and setters from the BHoM method list
2 participants