Skip to content

Updating supported versions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This toolkit allows interoperability between the BHoM and SAP2000. Enables creat
[SAP2000 Product Website](https://www.csiamerica.com/products/sap2000)

### Known Versions of Software Supported
SAP2000 version 21
The adapter is intended to support SAP2000 version 21 and all future versions. It is currently tested on version 23 exclusively.

### Documentation
For more information about functionality see [Object Relation Table](https://github.com/BHoM/SAP2000_Toolkit/wiki/BHoM-SAP2000-Object-Relations)
Expand Down
3 changes: 3 additions & 0 deletions SAP2000_Adapter/SAP2000Adapter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
using System.IO;
using BH.oM.Adapters.SAP2000;
using BH.oM.Adapter.Commands;
using System.ComponentModel;
using BH.oM.Base.Attributes;
using BH.Engine.Adapter;

namespace BH.Adapter.SAP2000
Expand All @@ -41,6 +43,7 @@ public partial class SAP2000Adapter : BHoMAdapter
/**** Constructors ****/
/***************************************************/

[Description("Creates an adapter supporting SAP2000v21 and later.")]
public SAP2000Adapter(string filePath = "", bool active = false)
{

Expand Down
8 changes: 6 additions & 2 deletions SAP2000_Engine/Query/JoinRigidLink.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
using System.Collections.Generic;
using System.Linq;
using BH.oM.Structure.Constraints;
using BH.oM.Base.Attributes;
using System.ComponentModel;
using BH.Engine.Base;

namespace BH.Engine.Adapters.SAP2000
Expand All @@ -35,8 +37,10 @@ public static partial class Query
/***************************************************/
/**** Public Methods ****/
/***************************************************/

public static List<RigidLink> JoinRigidLink(List<RigidLink> linkList)
[Description("Joins RigidLinks split by SplitRigidLink() into RigidLinks with multiple SecondaryNodes.")]
[Input("linkList", "The RigidLinks to be joined; only links containing ':::' will be joined.")]
[Output("JoinedLinks", "A list of RigidLinks with one or more SecondaryNodes")]
public static List<RigidLink> JoinRigidLink(this List<RigidLink> linkList)
{
Dictionary<string, RigidLink> joinedList = new Dictionary<string, RigidLink>();

Expand Down