Skip to content

Updating supported versions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

JosefTaylor
Copy link
Contributor

@JosefTaylor JosefTaylor commented Feb 2, 2022

@JosefTaylor
Copy link
Contributor Author

JosefTaylor commented Feb 9, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • installer

There are 4 requests in the queue ahead of you.

@JosefTaylor JosefTaylor self-assigned this Feb 9, 2022
@JosefTaylor
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

@JosefTaylor to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@JosefTaylor JosefTaylor requested a review from mchaf February 9, 2022 23:19
@JosefTaylor
Copy link
Contributor Author

Hey @murali-manoj , I know you won't be able to use this because you haven't got SAPv21, but could you check that you get a reasonable error message which tells you that SAPv20 is not supported?

@mchaf can you make sure this builds and runs? Basic functionality only.

IsakNaslundBh
IsakNaslundBh previously approved these changes Jan 5, 2023
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes are to Read me and Descriptions added. Approving on this basis and code review.

@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 5, 2023 13:56
@IsakNaslundBh IsakNaslundBh dismissed their stale review January 5, 2023 13:56

The base branch was changed.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 10 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving on same basis as above.

@IsakNaslundBh IsakNaslundBh added the type:documentation Wiki, help or in code attributes label Jan 5, 2023
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 0667a62 into develop Jan 5, 2023
@IsakNaslundBh IsakNaslundBh deleted the SAP2000_Toolkit-#255-documentation-update branch January 5, 2023 14:03
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme out of date
2 participants