-
Notifications
You must be signed in to change notification settings - Fork 2
Updating supported versions #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating supported versions #256
Conversation
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
|
@BHoMBot check compliance |
@JosefTaylor to confirm, the following checks are now queued:
|
The check |
@BHoMBot check installer |
@JosefTaylor to confirm, the following checks are now queued:
|
The check |
@JosefTaylor to confirm, the following checks are now queued:
There are 4 requests in the queue ahead of you. |
@BHoMBot check required |
@JosefTaylor to confirm, the following checks are now queued:
|
The check |
The check |
The check |
Hey @murali-manoj , I know you won't be able to use this because you haven't got SAPv21, but could you check that you get a reasonable error message which tells you that SAPv20 is not supported? @mchaf can you make sure this builds and runs? Basic functionality only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only changes are to Read me and Descriptions added. Approving on this basis and code review.
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving on same basis as above.
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #255
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23256-documentation-update?csf=1&web=1&e=HrxMnn
Changelog
Additional comments