Skip to content

Remove Revit 2020 support #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

michal-pekacki
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #1527

Removed Revit 2020 support and updated the code.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Jan 15, 2025
@michal-pekacki michal-pekacki self-assigned this Jan 15, 2025
vietle-bh
vietle-bh previously approved these changes Jan 15, 2025
Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to see any problem with it 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 15, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jan 15, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 17 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 15, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 15, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 15, 2025

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 15, 2025

@michal-pekacki just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Installer

Copy link

bhombot-ci bot commented Jan 15, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 16, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 17, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 17, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving after versioning fix 👍

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 17, 2025

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 55f7a8d into develop Jan 17, 2025
11 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1527-RemoveRevit2020Support branch January 17, 2025 12:55
@michal-pekacki michal-pekacki restored the Revit_Toolkit-#1527-RemoveRevit2020Support branch January 30, 2025 14:13
@michal-pekacki michal-pekacki deleted the Revit_Toolkit-#1527-RemoveRevit2020Support branch January 30, 2025 14:14
@adecler adecler mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Revit 2020 support
3 participants