Skip to content

Get a venv PythonEnvironment object from an environment name #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

jamesramsden-bh
Copy link
Contributor

Closes #95

A lightweight method to get a PythonEnvironment object for a virtual environment without the overheads of attempting to install said environment.

Test by:

@jamesramsden-bh jamesramsden-bh added the type:feature New capability or enhancement label Feb 14, 2023
@jamesramsden-bh jamesramsden-bh self-assigned this Feb 14, 2023
@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyrght-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

tg359
tg359 previously approved these changes Mar 1, 2023
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to changes to the copyright headers (after which I give it both thumbs up!), I've tested this and it works well to speed up the existing environment loading process.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 11669880735

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 11669880735

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@tg359 tg359 self-requested a review March 1, 2023 09:45
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enjoy copyright headers that show the current year. I approve. For serious notes see my previous approval.

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 1, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit fb56683 into develop Mar 1, 2023
@FraserGreenroyd FraserGreenroyd deleted the Python_Toolkit-#95-GetVEnvObject branch March 1, 2023 16:43
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get an environment object for a given environment name
4 participants