Skip to content

Add multitude of features to the toolkit #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 89 commits into from
Jun 8, 2023

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Feb 10, 2023

Issues addressed by this PR

Closes #89

@tg359 to add list of new features here

Test files

Depends on

Build this first before testing:
BHoM/Python_Toolkit#96

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check versioning

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check serialisation
@BHoMBot check project-compliance
@BHoMBot check null-handling
@BHoMBot check documentation-compliance
@BHoMBot check dataset-compliance
@BHoMBot check core
@BHoMBot check copyright-compliance
@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check unit-tests
  • check serialisation
  • check project-compliance
  • check null-handling
  • check documentation-compliance
  • check dataset-compliance
  • check core
  • check copyright-compliance
  • check code-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check installer

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code through with @jamesramsden-bh and am happy my changes have been addressed and this work is working suitably for the work done by @tg359 and @jamesramsden-bh so happy for this to be merged and deployed in 6.2

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

FAO: @FraserGreenroyd
@jamesramsden-bh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14110585378

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14110585378

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd I have now provided a passing check on reference 14110585378 as requested.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 163f4a1 into develop Jun 8, 2023
@jamesramsden-bh jamesramsden-bh deleted the LBT_Toolkit-#XX-ProjectChanges branch June 8, 2023 15:50
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs size:L Measured in days type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add many new features to LBT_Toolkit
4 participants