Skip to content

6.1 Deployment #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 28, 2023
Merged

6.1 Deployment #342

merged 8 commits into from
Mar 28, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

MidasCivil_Toolkit

Compliance

External-api-changes

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 56 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 13, 2023
@IsakNaslundBh IsakNaslundBh requested review from StephennipBH and peterjamesnugent and removed request for IsakNaslundBh March 14, 2023 07:23
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 55 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:17.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality of push pull of bar and femesh elements under different properties have been tested. Loadings have not been tested yet

@FraserGreenroyd
Copy link
Contributor

Owing to a lack of reviews signing off this repository for all of the changes proposed to this beta, I am unable to deploy this pull request to the 6.1 beta. Unfortunately it is also blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation
  • check core

There are 34 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation
  • check core

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as code is identical to #344:

Checked using the two following scripts:
Structures - Create - Read - Update - Elements
Structures - Create read loads

Both loaded in to MidasCivil correctly, no errors (apart from unsupported loads).

There were some reported different values, but I suspect it's due to the same names being used (I made a separate script for previous installers) - a few spot checks confirmed the same loads were pushing/pulled and shown in the software.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12326508415

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12326508415

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12326508415 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 28, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 4b87ff5 into main Mar 28, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants