Skip to content

Temporarily turning off caching system #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #343

Temporary turn off caching system

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Mar 27, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 27, 2023
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 14 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh changed the title Temporary turn off caching system Temporarily turning off caching system Mar 27, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked using the two following scripts:
Structures - Create - Read - Update - Elements
Structures - Create read loads

Both loaded in to MidasCivil correctly, no errors (apart from unsupported loads).

There were some reported different values, but I suspect it's due to the same names being used (I made a seperate script for previous installers) - a few spot checks confirmed the same loads were pushing/pulled and shown in the software.

@peterjamesnugent
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit cb2796c into develop Mar 28, 2023
@IsakNaslundBh IsakNaslundBh deleted the MidasCivil_Toolkit-#343-TemporaryTurnOffCachingSystem branch March 28, 2023 05:41
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary turn off caching system
2 participants