Skip to content

Fix pull openings and reading a BHoM GEM file by fixing the push of the GEM file #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Fix pull openings and reading a BHoM GEM file by fixing the push of the GEM file #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
766461e
Fix #218
Mar 21, 2023
68837a8
Fix #217
Mar 21, 2023
279b97e
Fix formatting issues in GEM create
Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions IES_Adapter/CRUD/Create.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ protected override bool ICreate<T>(IEnumerable<T> objects, ActionConfig actionCo

StreamWriter sw = new StreamWriter(_fileSettings.GetFullFileName());

sw.WriteLine("COM GEM data file exported by BHoM");
sw.WriteLine("CAT"); //Lol - Default GEM files use ANT
sw.WriteLine("SITE");
sw.WriteLine("51.378 2.3648 0.000 0.000");

try
{
foreach (List<Panel> space in panelsAsSpaces)
Expand Down
3 changes: 2 additions & 1 deletion IES_Adapter/Convert/Environment/Space.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ public static List<Panel> FromIES(this List<string> iesSpace, SettingsIES settin
for (int x = 0; x < numCoords; x++)
openingPts.Add(iesSpace[count + x]);

panel.Openings.Add(openingPts.FromIESOpening(openingData.Split(' ')[1], pLine, settingsIES));
if(settingsIES.PullOpenings)
panel.Openings.Add(openingPts.FromIESOpening(openingData.Split(' ')[1], pLine, settingsIES));

count += numCoords;
countOpenings++;
Expand Down