Fix pull openings and reading a BHoM GEM file by fixing the push of the GEM file #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested review from
rboulton-BH,
jamesramsden-bh,
EKAdebo,
kprusicka and
CKBoulter
rboulton-BH
previously approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Tested using the IES_Toolkit testing procedure and additional step of Pulling one of the GEM files created by the BHoM Push as suggested in the issues raised. The PullOpenings toggle now works correctly and it is now possible to Pull a GEM file created by BHoM. This meets my approval
rboulton-BH
approved these changes
Mar 21, 2023
|
@BHoMBot check required |
|
@rboulton-BH to confirm, the following actions are now queued:
|
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
Fixes #218
Fix for #218 is provided by fixing the push of the BHoM GEM file to include data which was previously missing.