Skip to content

Add Get Joint Accelerations #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Aug 14, 2024

Issues addressed by this PR

Closes #460

GH Script - Success - After Pull Request

ETABS Outputs - Success

ETABS Toolkit now can allow to extract joint accelerations outputs from ETABS.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/s/BHoM/ESMRcVgt7RBDmxfhsz9HF_4BZOKpp9A_JYihkY1BjTNIGw?e=AJjNUE
ETABS File
https://burohappold.sharepoint.com/:i:/s/BHoM/EfzC47OrWThIof0lXaPvMX0BTg-mcMYKC1zuJkQ4Nais-A?e=uF0gSf

Changelog

  • Added ReadNodeAcceleration Method to retrieve Abs Joint Accelerations from ETABS

@GCRA101 GCRA101 added the type:feature New capability or enhancement label Aug 14, 2024
@GCRA101 GCRA101 added this to the BHoM 7.3 β MVP milestone Aug 14, 2024
@GCRA101 GCRA101 self-assigned this Aug 14, 2024
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested with test script provided. Functionality works as intended. PR Approved.

@Chrisshort92
Copy link
Contributor

@BHoMBot bot check required

Copy link

bhombot-ci bot commented Aug 30, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 9 requests in the queue ahead of you.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the NodeVelocity, happy with @Chrisshort92's functionality review and I am happy with the code.

@peterjamesnugent peterjamesnugent merged commit aebab56 into develop Sep 4, 2024
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#460-AddGetJointAccelerations branch September 4, 2024 19:14
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feature to Retrieve Joint Accelerations
3 participants