Skip to content

Verification_Engine: code tweaked to enable special treatment of Revit parameters #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Helps closing BHoM/Revit_Toolkit#1545

Test files

#3431
#3465
#3460
#3454

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 21, 2025
@pawelbaran pawelbaran self-assigned this Mar 21, 2025
@pawelbaran pawelbaran changed the title Versioning_Engine: code tweaked to enable special treatment of Revit parameters Verification_Engine: code tweaked to enable special treatment of Revit parameters Mar 21, 2025
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 21, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 21, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Mar 21, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 21, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works as expected, happy to approve 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Mar 21, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 21, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 65779c6 into develop Mar 21, 2025
13 checks passed
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1545-FilteringByElementIdBug branch March 21, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants