Verification_Engine added

[pawelbaran]

NOTE: Depends on

BHoM/BHoM#1644

Issues addressed by this PR

Supports BHoM/BHoM#1643

Test files

On SharePoint

Changelog

Additional comments

@alelom please note that the GH script mentioned under test files contains a suite of tests that fail to serialise due to a diffing bug - I will try to extract the exact culprit and raise an issue for you to debug. Once the bug gets fixed, I will gladly push UTs for this PR.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 5 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

@BHoMBot check core

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

[michal-pekacki]

If we compare two strings with LessThan and GreaterThan comparison type the result for both is False and we have following entry in the report:

Shouldn't we disable numeric comparisons for strings?

[pawelbaran]

Thanks @michal-pekacki, I've just fixed that, returning null as inconclusive in such cases 👍

[michal-pekacki]

Shouldn't we be consistent and do the same when comparing number to string?
In following entry comparing numeric ValueSource with string ReferenceValue doesn't return null:

[pawelbaran]

Ha, I disabled comparing numbers to strings now, thanks for another good catch @michal-pekacki 👍 also added test cases

[michal-pekacki]

Looks good! I have no more comments, happy to approve 👍

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 4 requests in the queue ahead of you.

[bhombot-ci]

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check unit-tests

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance
• check unit-tests

[pawelbaran]

@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check ready-to-merge