-
Notifications
You must be signed in to change notification settings - Fork 13
Reflection_Engine: Subtypes query added #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FraserGreenroyd
merged 8 commits into
develop
from
Reflection_Engine-#2964-SubtypesQuery
Jan 9, 2023
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e3a9b7b
Subtypes query added
pawelbaran d79eeed
tweak to avoid code duplication
pawelbaran bcd44fc
I/O descriptions added
pawelbaran 219e637
tweaks to account for the fact that only BHoM, non-interface types ar…
pawelbaran 9229025
copyright upticked
pawelbaran 1e5ac61
bugfixing
pawelbaran 842455b
UTs added
pawelbaran 9fc4878
Delete subtypes unit test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,8 +24,6 @@ | |
using System; | ||
using System.Collections.Generic; | ||
using System.ComponentModel; | ||
using System.Linq; | ||
using System.Reflection; | ||
|
||
namespace BH.Engine.Reflection | ||
{ | ||
|
@@ -35,7 +33,9 @@ public static partial class Query | |
/**** Public Methods ****/ | ||
/***************************************************/ | ||
|
||
[Description("Returns all the loaded types that implement the specified interface.")] | ||
[Description("Returns all loaded BHoM types that implement the specified interface.")] | ||
[Input("@interface", "Interface to find its implementing types.")] | ||
[Output("implementingTypes", "Collection of BHoM types that implement the input interface.")] | ||
public static List<Type> ImplementingTypes(this Type @interface) | ||
{ | ||
if(@interface == null) | ||
|
@@ -47,13 +47,7 @@ public static List<Type> ImplementingTypes(this Type @interface) | |
if ([email protected]) | ||
return new List<Type>(); | ||
|
||
List<Type> implemented = new List<Type>(); | ||
foreach (Type t in Base.Query.BHoMTypeList()) | ||
{ | ||
if (@interface.IsAssignableFrom(t)) | ||
implemented.Add(t); | ||
} | ||
return implemented; | ||
return @interface.Subtypes(); | ||
} | ||
|
||
/***************************************************/ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* This file is part of the Buildings and Habitats object Model (BHoM) | ||
* Copyright (c) 2015 - 2023, the respective contributors. All rights reserved. | ||
* | ||
* Each contributor holds copyright over their respective contributions. | ||
* The project versioning (Git) records all such contribution source information. | ||
* | ||
* | ||
* The BHoM is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Lesser General Public License as published by | ||
* the Free Software Foundation, either version 3.0 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* The BHoM is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Lesser General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Lesser General Public License | ||
* along with this code. If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>. | ||
*/ | ||
|
||
using BH.oM.Base.Attributes; | ||
using System; | ||
using System.Collections.Generic; | ||
using System.ComponentModel; | ||
|
||
namespace BH.Engine.Reflection | ||
{ | ||
public static partial class Query | ||
{ | ||
/***************************************************/ | ||
/**** Public Methods ****/ | ||
/***************************************************/ | ||
|
||
[Description("Returns all loaded BHoM types that inherit from the specified parent type.")] | ||
[Input("parentType", "Parent type of the subtypes to be returned.")] | ||
[Output("subtypes", "Collection of BHoM subtypes of the input parent type.")] | ||
public static List<Type> Subtypes(this Type parentType) | ||
{ | ||
if (parentType == null) | ||
{ | ||
Base.Compute.RecordWarning("Cannot query the subtypes of a null type."); | ||
return new List<Type>(); | ||
} | ||
|
||
List<Type> implemented = new List<Type>(); | ||
foreach (Type t in Base.Query.BHoMTypeList()) | ||
{ | ||
if (parentType.IsAssignableFrom(t)) | ||
implemented.Add(t); | ||
} | ||
|
||
return implemented; | ||
} | ||
|
||
/***************************************************/ | ||
} | ||
} | ||
|
||
|
||
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.