Reflection_Engine: Subtypes query added

[pawelbaran]

Issues addressed by this PR

Closes #2964

Test files

On SharePoint

Changelog

ImplementingTypes and Subtypes are essentially the same method, but I did not dare to merge them taken slightly different use cases (at least in my mind). However, happy to do it if requested in the review.

Additional comments

[FraserGreenroyd]

I can see the primary differences between the methods is that one is specifically for interfaces and the other (the new one, SubTypes) is not.

Originally, I would say I wouldn't see the point of the second given the BHoM inheritance structure prohibits object inheritance, however we have broken that rule in strategic places, so I can see a reason for wanting to know the subtypes of non-interface types.

But I'm not sure we need two methods to achieve this. I think a bool flag on ImplementingTypes for interfaceOnly would suffice? While I like the attempt to keep it tidy by having one call the other, I'm just not convinced the use case for individual methods is that strong as opposed to a modification of the existing one?

Though maybe the default bool could cause confusion so I can also see an argument for having them as separate methods... Happy to see what others think for a final decision I think.

[pawelbaran]

Hmm, I got confused now @FraserGreenroyd. The facts as I see them:

• both methods return only non-abstract, non-interface BHoM types
• ImplementingTypes method accepts only interface types, while Subtypes will be happy with any input of type Type
• technically ImplementingTypes is the same method as Subtypes, just more strict on the input properties

...bool input parameter seems a bit redundant to me in this case, I was more considering whether we need ImplementingTypes altogether. Or am I missing something?

[FraserGreenroyd]

Happy with the discussion from above - could we generate a unit test for this before merge though @pawelbaran ?

[pawelbaran]

I will generate UTs on Monday @FraserGreenroyd - thanks!

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

Following review of the unit test @pawelbaran built, it has been determined that this won't work with the overall unit test strategy as originally thought so I have removed the unit test for now to be revisited in the future.

@BHoMBot check compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[FraserGreenroyd]

@BHoMBot check versioning
@BHoMBot check required

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 7 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests
• check ready-to-merge

[FraserGreenroyd]

Code works and looks good, happy to deploy to support the Mongo work as this can be merged independently.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.