Skip to content

Fix incorrect null check on Tag prior to Push via FullCRUD #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Fix incorrect null check on Tag prior to Push via FullCRUD #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BHoM_Adapter/AdapterActions/_PushMethods/CRUDDispatchers/FullCRUD.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ protected bool FullCRUD<T>(IEnumerable<T> objectsToPush, PushType pushType = Pus
// Make sure objects are distinct
List<T> newObjects = objectsToPush.Distinct(Engine.Adapter.Query.GetComparerForType<T>(this)).ToList();

// Make sure objects are tagged
if (tag != "")
// Add the tag if provided
if (!string.IsNullOrWhiteSpace(tag))
newObjects.ForEach(x => x.Tags.Add(tag));

//Read all the objects of that type from the external model
Expand Down