Skip to content

Fix incorrect null check on Tag prior to Push via FullCRUD #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

alelom
Copy link
Member

@alelom alelom commented Nov 3, 2022

Issues addressed by this PR

Closes #326

Fix an incorrect null check on tags. There was no guard against null values.

Test files

See #326

Changelog

Additional comments

@alelom alelom self-assigned this Nov 3, 2022
@alelom alelom added type:bug Error or unexpected behaviour size:XS Measured in seconds labels Nov 3, 2022
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with script where the null tag was causing a failed push and the push now works as expected.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 3, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd changed the title BHoM_Adapter: fix incorrect null check on Tag prior to Push via FullCRUD Fix incorrect null check on Tag prior to Push via FullCRUD Nov 3, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is sensible given the issue described and this should resolve it.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 7902708 into main Nov 3, 2022
@FraserGreenroyd FraserGreenroyd deleted the #326-InvalidTagCheck branch November 3, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS Measured in seconds type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Adapter: Tag check bug adds null tag to tags before push
3 participants