Skip to content

Update benchmark-action.yml to use net 9 #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Update benchmark-action.yml to use net 9 #3268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
caa3fbe
Update benchmark-action.yml to use net 9
gladjohn Feb 26, 2025
7322f45
Update Directory.Build.props
gladjohn Feb 26, 2025
0f5e566
Update Directory.Build.props
gladjohn Feb 27, 2025
4b02f56
Update AssemblyOriginatorKeyFile path in props
gladjohn Feb 27, 2025
bd52dfa
Update checkout step in benchmark workflow
gladjohn Feb 27, 2025
3246d48
Fix indentation in benchmark-action workflow
gladjohn Feb 27, 2025
9eaf23f
Disable assembly signing and delay signing
gladjohn Feb 27, 2025
6cf5e29
Update benchmark workflow and dotnet version
gladjohn Feb 27, 2025
da17810
Fix workflow steps and dotnet version
gladjohn Feb 27, 2025
059b428
Update benchmark action workflow configuration
gladjohn Feb 27, 2025
a21fc56
Update benchmark-action workflow configuration
gladjohn Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/benchmark-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@ jobs:
AzureAd__ClientCredentials__0__SourceType: "ClientSecret"
AzureAd__ClientCredentials__0__ClientSecret: ${{secrets.ClientSecret}}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v4

- uses: actions/setup-dotnet@v4
with:
dotnet-version: '8.x'
dotnet-version: '9.x'
- name: Run benchmark
run: cd benchmark && dotnet run -c release -f net8.0 --filter 'Benchmarks.TokenAcquisitionBenchmark.*' --exporters json
run: cd benchmark && dotnet run -c release -f net9.0 --filter 'Benchmarks.TokenAcquisitionBenchmark.*' --exporters json

- name: Download previous benchmark data
uses: actions/cache@v4
Expand All @@ -40,10 +41,11 @@ jobs:
output-file-path: benchmark/BenchmarkDotNet.Artifacts/results/Benchmarks.TokenAcquisitionBenchmark-report-full-compressed.json
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: true
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '130%'
comment-on-alert: true
fail-on-alert: true
summary-always: true
gh-pages-branch: gh-pages
alert-threshold: '130%'
comment-on-alert: true

benchmark-data-dir-path: benchmarks
gh-pages-branch: gh-pages
benchmark-data-dir-path: benchmarks
benchmark-data-dir-path: benchmarks
benchmark-data-dir-path: benchmarks
Expand Down
7 changes: 3 additions & 4 deletions benchmark/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
<PropertyGroup>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks>net9.0</TargetFrameworks>
<IsPackable>false</IsPackable>
<EnablePackageValidation>false</EnablePackageValidation>
<SignAssembly>True</SignAssembly>
<DelaySign>True</DelaySign>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)..\build\msal.snk</AssemblyOriginatorKeyFile>
<SignAssembly>False</SignAssembly> <!-- Disable Signing -->
<DelaySign>False</DelaySign> <!-- Disable Delay Signing -->
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
Loading