Skip to content

Update benchmark-action.yml to use net 9 #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Update benchmark-action.yml to use net 9 #3268

wants to merge 11 commits into from

Conversation

gladjohn
Copy link
Contributor

@gladjohn gladjohn commented Feb 26, 2025 •
edited
Loading

Update benchmark-action.yml to use net 9

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This pull request includes updates to the .github/workflows/benchmark-action.yml file to ensure compatibility with the latest .NET version.

  • Updated the dotnet-version from '8.x' to '9.x' in the actions/setup-dotnet step to use the latest .NET version.
  • Modified the dotnet run command to target net9.0 instead of net8.0 in the Run benchmark step.

Fixes #3270

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/26/2025 - 9:11:13 PM
Coverage date: 2/26/2025 - 9:10:24 PM - 2/26/2025 - 9:11:10 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@gladjohn gladjohn changed the title [DRAFT] Update benchmark-action.yml to use net 9 Update benchmark-action.yml to use net 9 Feb 26, 2025
@gladjohn gladjohn marked this pull request as ready for review February 26, 2025 21:37
@gladjohn gladjohn requested a review from a team as a code owner February 26, 2025 21:37
@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/26/2025 - 9:50:43 PM
Coverage date: 2/26/2025 - 9:49:57 PM - 2/26/2025 - 9:50:40 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@gladjohn
Copy link
Contributor Author

OB Run for this PR Branch - https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1437032&view=results

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 12:11:48 AM
Coverage date: 2/27/2025 - 12:11:01 AM - 2/27/2025 - 12:11:45 AM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@jennyf19
Copy link
Collaborator

was a build failing because of this? trying to understand the prioritization. thanks

@gladjohn
Copy link
Contributor Author

gladjohn commented Feb 27, 2025 •
edited
Loading

was a build failing because of this? trying to understand the prioritization. thanks

builds aren't failing, but the benchmark action post merge to main has been failing to run for a while.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:08:44 PM
Coverage date: 2/27/2025 - 10:07:48 PM - 2/27/2025 - 10:08:40 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:12:21 PM
Coverage date: 2/27/2025 - 10:11:20 PM - 2/27/2025 - 10:12:14 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:16:52 PM
Coverage date: 2/27/2025 - 10:15:59 PM - 2/27/2025 - 10:16:47 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:19:56 PM
Coverage date: 2/27/2025 - 10:19:03 PM - 2/27/2025 - 10:19:51 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:20:47 PM
Coverage date: 2/27/2025 - 10:19:48 PM - 2/27/2025 - 10:20:41 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@gladjohn gladjohn closed this Feb 27, 2025
@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:25:09 PM
Coverage date: 2/27/2025 - 10:24:13 PM - 2/27/2025 - 10:25:04 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:25:37 PM
Coverage date: 2/27/2025 - 10:24:37 PM - 2/27/2025 - 10:25:31 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:26:22 PM
Coverage date: 2/27/2025 - 10:25:27 PM - 2/27/2025 - 10:26:17 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/27/2025 - 10:29:01 PM
Coverage date: 2/27/2025 - 10:28:05 PM - 2/27/2025 - 10:28:56 PM
Parser: MultiReport (3x Cobertura)
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors

Coverage

No assemblies have been covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions Fails Due to Missing .NET SDK 9.0
3 participants
@gladjohn @jennyf19 @bgavrilMS