[Core] Wiring up rehydration token logic in data-plane #49224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
kinelski
commented
Apr 3, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews Azure.AI.FormRecognizer |
jsquire
reviewed
Apr 4, 2025
There was a problem hiding this comment.
Looks fine to me, but I'll ask that @JoshLove-msft and @m-nash be the authoritative approvals here, as there are generator and management plane implications.
m-nash
reviewed
Apr 12, 2025
JoshLove-msft
approved these changes
Apr 24, 2025
m-nash
reviewed
Apr 28, 2025
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
m-nash
reviewed
Apr 29, 2025
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
kinelski
requested review from
schaabs,
JonathanCrd and
christothes
as code owners
kinelski
requested review from
MikeyMCZ,
joseharriaga,
vikaspalaskar and
quentinRobinson
as code owners
kinelski
commented
Apr 30, 2025
sdk/keyvault/Azure.Security.KeyVault.Certificates/src/DeleteCertificateOperation.cs
Outdated
Show resolved
Hide resolved
kinelski
requested review from
ArcturusZhang,
ArthurMa1978,
PallabPaul,
amruthashree18,
andpiccione and
ivarprudnikov
as code owners
m-nash
approved these changes
May 7, 2025
christothes
reviewed
May 8, 2025
christothes
approved these changes
May 8, 2025
|
API change check API changes are not detected in this pull request. |
christothes
approved these changes
May 8, 2025
joseharriaga
approved these changes
May 9, 2025
ArthurMa1978
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DPG libraries do not support rehydrating long-running operations. This means that, after a long-running operation has been started, users must hold their
Operation<T>reference until its completion in order to access its final result. This can be a problem as some operations could take hours or even days to complete.Our TypeSpec code generator already supports the creation of rehydration tokens to retrieve the status of long-running operations, but the logic to do so had not been wired into our
OperationAPI yet.Fixes #48594.