Throwing NotSupported across the board

kinelski · kinelski · commit 0acf72d3f53f · 2025-05-06T13:15:55.000-07:00
diff --git a/sdk/communication/Azure.Communication.Email/src/EmailSendOperation.cs b/sdk/communication/Azure.Communication.Email/src/EmailSendOperation.cs
@@ -184,6 +184,10 @@ async ValueTask<OperationState<EmailSendResult>> IOperation<EmailSendResult>.Upd
             return OperationState<EmailSendResult>.Pending(rawResponse);
         }
 
+        // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
+        RehydrationToken IOperation<EmailSendResult>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
+
         private static IDictionary<string, string> CreateAdditionalInformation(ErrorDetail error)
         {
             if (string.IsNullOrEmpty(error.ToString()))
diff --git a/sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/PostLedgerEntryOperation.cs b/sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/PostLedgerEntryOperation.cs
@@ -79,6 +79,10 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
             return OperationState.Pending(statusResponse);
         }
 
+        // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
+
         /// <summary>
         /// The transactionId of the posted ledger entry.
         /// </summary>
diff --git a/sdk/core/Azure.Core/src/Shared/OperationInternalBase.cs b/sdk/core/Azure.Core/src/Shared/OperationInternalBase.cs
@@ -185,12 +185,6 @@ public Response WaitForCompletionResponse(CancellationToken cancellationToken)
         public Response WaitForCompletionResponse(TimeSpan pollingInterval, CancellationToken cancellationToken)
             => WaitForCompletionResponseAsync(async: false, pollingInterval, _waitForCompletionResponseScopeName, cancellationToken).EnsureCompleted();
 
-        /// <summary>
-        /// Get a token that can be used to rehydrate the operation.
-        /// </summary>
-        public RehydrationToken GetRehydrationToken(RequestMethod requestMethod, Uri startRequestUri, OperationFinalStateVia finalStateVia)
-            => NextLinkOperationImplementation.GetRehydrationToken(requestMethod, startRequestUri, RawResponse, finalStateVia);
-
         protected async ValueTask<Response> WaitForCompletionResponseAsync(bool async, TimeSpan? pollingInterval, string scopeName, CancellationToken cancellationToken)
         {
             // If _responseLock has the value, lockOrValue will contain that value, and no lock is acquired.
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Certificates/src/DeleteCertificateOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Certificates/src/DeleteCertificateOperation.cs
@@ -116,6 +116,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Certificates/src/RecoverDeletedCertificateOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Certificates/src/RecoverDeletedCertificateOperation.cs
@@ -106,6 +106,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Keys/src/DeleteKeyOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Keys/src/DeleteKeyOperation.cs
@@ -116,6 +116,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Keys/src/RecoverDeletedKeyOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Keys/src/RecoverDeletedKeyOperation.cs
@@ -106,6 +106,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/DeleteSecretOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/DeleteSecretOperation.cs
@@ -112,6 +112,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/RecoverDeletedSecretOperation.cs b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/RecoverDeletedSecretOperation.cs
@@ -102,6 +102,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation.GetRehydrationToken() => default;
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/resourcemanager/Azure.ResourceManager/tests/TestFramework/MockOperation.cs b/sdk/resourcemanager/Azure.ResourceManager/tests/TestFramework/MockOperation.cs
@@ -119,6 +119,9 @@ public ValueTask<OperationState> UpdateStateAsync(bool async, CancellationToken
             return new ValueTask<OperationState>(OnUpdateState(cancellationToken));
         }
 
+        RehydrationToken IOperation.GetRehydrationToken() =>
+            throw new NotImplementedException();
+
         public MockOperationInternal MockOperationInternal { get; }
 
         public Func<CancellationToken, OperationState> OnUpdateState { get; set; }
diff --git a/sdk/resourcemanager/Azure.ResourceManager/tests/TestFramework/MockOperationOfT.cs b/sdk/resourcemanager/Azure.ResourceManager/tests/TestFramework/MockOperationOfT.cs
@@ -129,6 +129,9 @@ ValueTask<OperationState<T>> IOperation<T>.UpdateStateAsync(bool async, Cancella
             return new ValueTask<OperationState<T>>(OnUpdateState(cancellationToken));
         }
 
+        RehydrationToken IOperation<T>.GetRehydrationToken() =>
+            throw new NotImplementedException();
+
         internal MockOperationInternal<T> MockOperationInternal { get; }
 
         internal Func<CancellationToken, OperationState<T>> OnUpdateState { get; set; }
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/AbstractiveSummarizeOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/AbstractiveSummarizeOperation.cs
@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<AbstractiveSummarizeResultCollectio
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<AbstractiveSummarizeResultCollection>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<AbstractiveSummarizeResultCollection>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOperation.cs
@@ -322,7 +322,8 @@ async ValueTask<OperationState<AsyncPageable<AnalyzeActionsResult>>> IOperation<
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<AnalyzeActionsResult>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<AnalyzeActionsResult>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
 
         private AsyncPageable<AnalyzeActionsResult> CreateOperationValueAsync(CancellationToken cancellationToken = default)
         {
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeHealthcareEntitiesOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeHealthcareEntitiesOperation.cs
@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<AnalyzeHealthcareEntitiesResultColl
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<AnalyzeHealthcareEntitiesResultCollection>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<AnalyzeHealthcareEntitiesResultCollection>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/ClassifyDocumentOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/ClassifyDocumentOperation.cs
@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<ClassifyDocumentResultCollection>>>
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<ClassifyDocumentResultCollection>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<ClassifyDocumentResultCollection>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/ExtractiveSummarizeOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/ExtractiveSummarizeOperation.cs
@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<ExtractiveSummarizeResultCollection
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<ExtractiveSummarizeResultCollection>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<ExtractiveSummarizeResultCollection>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/textanalytics/Azure.AI.TextAnalytics/src/RecognizeCustomEntitiesOperation.cs b/sdk/textanalytics/Azure.AI.TextAnalytics/src/RecognizeCustomEntitiesOperation.cs
@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<RecognizeCustomEntitiesResultCollec
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<RecognizeCustomEntitiesResultCollection>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<RecognizeCustomEntitiesResultCollection>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
     }
 }
diff --git a/sdk/translation/Azure.AI.Translation.Document/src/DocumentTranslationOperation.cs b/sdk/translation/Azure.AI.Translation.Document/src/DocumentTranslationOperation.cs
@@ -241,7 +241,8 @@ async ValueTask<OperationState<AsyncPageable<DocumentStatusResult>>> IOperation<
         }
 
         // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.
-        RehydrationToken IOperation<AsyncPageable<DocumentStatusResult>>.GetRehydrationToken() => default;
+        RehydrationToken IOperation<AsyncPageable<DocumentStatusResult>>.GetRehydrationToken() =>
+            throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");
 
         private AsyncPageable<DocumentStatusResult> CreateOperationValueAsync(CancellationToken cancellationToken = default)
         {

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,10 @@ async ValueTask<OperationState<EmailSendResult>> IOperation<EmailSendResult>.Upd`
`184`	`184`	`return OperationState<EmailSendResult>.Pending(rawResponse);`
`185`	`185`	`}`
`186`	`186`
	`187`	`+ // This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
	`188`	`+ RehydrationToken IOperation<EmailSendResult>.GetRehydrationToken() =>`
	`189`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
	`190`	`+`
`187`	`191`	`private static IDictionary<string, string> CreateAdditionalInformation(ErrorDetail error)`
`188`	`192`	`{`
`189`	`193`	`if (string.IsNullOrEmpty(error.ToString()))`
Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`119`		`- RehydrationToken IOperation.GetRehydrationToken() => default;`
	`119`	`+ RehydrationToken IOperation.GetRehydrationToken() =>`
	`120`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`120`	`121`	`}`
`121`	`122`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`109`		`- RehydrationToken IOperation.GetRehydrationToken() => default;`
	`109`	`+ RehydrationToken IOperation.GetRehydrationToken() =>`
	`110`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`110`	`111`	`}`
`111`	`112`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`115`		`- RehydrationToken IOperation.GetRehydrationToken() => default;`
	`115`	`+ RehydrationToken IOperation.GetRehydrationToken() =>`
	`116`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`116`	`117`	`}`
`117`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ async ValueTask<OperationState> IOperation.UpdateStateAsync(bool async, Cancella`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`105`		`- RehydrationToken IOperation.GetRehydrationToken() => default;`
	`105`	`+ RehydrationToken IOperation.GetRehydrationToken() =>`
	`106`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`106`	`107`	`}`
`107`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,9 @@ public ValueTask<OperationState> UpdateStateAsync(bool async, CancellationToken`
`119`	`119`	`return new ValueTask<OperationState>(OnUpdateState(cancellationToken));`
`120`	`120`	`}`
`121`	`121`
	`122`	`+ RehydrationToken IOperation.GetRehydrationToken() =>`
	`123`	`+ throw new NotImplementedException();`
	`124`	`+`
`122`	`125`	`public MockOperationInternal MockOperationInternal { get; }`
`123`	`126`
`124`	`127`	`public Func<CancellationToken, OperationState> OnUpdateState { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,9 @@ ValueTask<OperationState<T>> IOperation<T>.UpdateStateAsync(bool async, Cancella`
`129`	`129`	`return new ValueTask<OperationState<T>>(OnUpdateState(cancellationToken));`
`130`	`130`	`}`
`131`	`131`
	`132`	`+ RehydrationToken IOperation<T>.GetRehydrationToken() =>`
	`133`	`+ throw new NotImplementedException();`
	`134`	`+`
`132`	`135`	`internal MockOperationInternal<T> MockOperationInternal { get; }`
`133`	`136`
`134`	`137`	`internal Func<CancellationToken, OperationState<T>> OnUpdateState { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -296,6 +296,7 @@ async ValueTask<OperationState<AsyncPageable<AbstractiveSummarizeResultCollectio`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`299`		`- RehydrationToken IOperation<AsyncPageable<AbstractiveSummarizeResultCollection>>.GetRehydrationToken() => default;`
	`299`	`+ RehydrationToken IOperation<AsyncPageable<AbstractiveSummarizeResultCollection>>.GetRehydrationToken() =>`
	`300`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`300`	`301`	`}`
`301`	`302`	`}`
Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,8 @@ async ValueTask<OperationState<AsyncPageable<AnalyzeActionsResult>>> IOperation<`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`325`		`- RehydrationToken IOperation<AsyncPageable<AnalyzeActionsResult>>.GetRehydrationToken() => default;`
	`325`	`+ RehydrationToken IOperation<AsyncPageable<AnalyzeActionsResult>>.GetRehydrationToken() =>`
	`326`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`326`	`327`
`327`	`328`	`private AsyncPageable<AnalyzeActionsResult> CreateOperationValueAsync(CancellationToken cancellationToken = default)`
`328`	`329`	`{`
Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,8 @@ async ValueTask<OperationState<AsyncPageable<DocumentStatusResult>>> IOperation<`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`// This method is never invoked since we don't override Operation<T>.GetRehydrationToken.`
`244`		`- RehydrationToken IOperation<AsyncPageable<DocumentStatusResult>>.GetRehydrationToken() => default;`
	`244`	`+ RehydrationToken IOperation<AsyncPageable<DocumentStatusResult>>.GetRehydrationToken() =>`
	`245`	`+ throw new NotSupportedException($"{nameof(GetRehydrationToken)} is not supported.");`
`245`	`246`
`246`	`247`	`private AsyncPageable<DocumentStatusResult> CreateOperationValueAsync(CancellationToken cancellationToken = default)`
`247`	`248`	`{`