Skip to content

Address APIReview comments #29668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Address APIReview comments #29668

merged 9 commits into from
Jul 7, 2022

Conversation

ArthurMa1978
Copy link
Member

No description provided.

@ArthurMa1978 ArthurMa1978 added Redis Cache Mgmt This issue is related to a management-plane library. labels Jul 6, 2022
@ArthurMa1978
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ArthurMa1978
Copy link
Member Author

/azp run net - redisenterprise - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 6, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Network

@ArthurMa1978 ArthurMa1978 changed the title Update readme.md for Redis Enterprise Address APIReview comments Jul 7, 2022
`zones` to `AvailabilityZones`
Change the `link` format to `ResourceIdentifier`
@fengzhou-msft
Copy link
Member

There is one more Format to change in API file: ServiceTagInformationPropertiesFormat

@ArthurMa1978 ArthurMa1978 enabled auto-merge (squash) July 7, 2022 15:33
@ArthurMa1978 ArthurMa1978 merged commit 99c39fe into main Jul 7, 2022
@ArthurMa1978 ArthurMa1978 deleted the mgmt-redisent branch July 7, 2022 16:23
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* Update readme.md

* Fix P2S

* Drop `Format` suffix
`zones` to `AvailabilityZones`
Change the `link` format to `ResourceIdentifier`

* Short `VirtualMachineId` to `VmId`

* Fix tests

* fix tests

* Change the format of body, cert data to `BinaryData`

* apiview
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
* Update readme.md

* Fix P2S

* Drop `Format` suffix
`zones` to `AvailabilityZones`
Change the `link` format to `ResourceIdentifier`

* Short `VirtualMachineId` to `VmId`

* Fix tests

* fix tests

* Change the format of body, cert data to `BinaryData`

* apiview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library. Network Redis Cache
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants