Skip to content

Commit 99c39fe

Browse files
authored
Address APIReview comments (#29668)
* Update readme.md * Fix P2S * Drop `Format` suffix `zones` to `AvailabilityZones` Change the `link` format to `ResourceIdentifier` * Short `VirtualMachineId` to `VmId` * Fix tests * fix tests * Change the format of body, cert data to `BinaryData` * apiview
1 parent 2e10135 commit 99c39fe

File tree

77 files changed

+738
-621
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+738
-621
lines changed

sdk/eventhub/Azure.ResourceManager.EventHubs/tests/Tests/EventHubNamespaceTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,19 +280,19 @@ public async Task SetGetNetworkRuleSets()
280280
{
281281
Name = "default1",
282282
AddressPrefix = "10.0.0.0/24",
283-
ServiceEndpoints = { new ServiceEndpointPropertiesFormat { Service = "Microsoft.EventHub" } }
283+
ServiceEndpoints = { new ServiceEndpointProperties { Service = "Microsoft.EventHub" } }
284284
},
285285
new SubnetData
286286
{
287287
Name = "default2",
288288
AddressPrefix = "10.0.1.0/24",
289-
ServiceEndpoints = { new ServiceEndpointPropertiesFormat { Service = "Microsoft.EventHub" } }
289+
ServiceEndpoints = { new ServiceEndpointProperties { Service = "Microsoft.EventHub" } }
290290
},
291291
new SubnetData
292292
{
293293
Name = "default3",
294294
AddressPrefix = "10.0.2.0/24",
295-
ServiceEndpoints = { new ServiceEndpointPropertiesFormat { Service = "Microsoft.EventHub" } }
295+
ServiceEndpoints = { new ServiceEndpointProperties { Service = "Microsoft.EventHub" } }
296296
}
297297
},
298298
Location = "eastus2"

sdk/network/Azure.ResourceManager.Network/api/Azure.ResourceManager.Network.netstandard2.0.cs

Lines changed: 88 additions & 88 deletions
Large diffs are not rendered by default.

sdk/network/Azure.ResourceManager.Network/src/Generated/ApplicationGatewayData.cs

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/network/Azure.ResourceManager.Network/src/Generated/DdosCustomPolicyData.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/network/Azure.ResourceManager.Network/src/Generated/Extensions/NetworkExtensions.cs

Lines changed: 21 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/network/Azure.ResourceManager.Network/src/Generated/Extensions/ResourceGroupResourceExtensionClient.cs

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)