Skip to content

tsp, internalApi generate model classes #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Sep 12, 2023

fix #2286

  • re-enable @access(Access.internal) on API to generate models class in impl package, as well as package private conenience API
  • treat @include as @access(Access.public) (till it get deprecated)

@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Sep 13, 2023

possible configure for OpenAI

@@access(Azure.OpenAI.AzureChatExtensionConfiguration, Access.public, "java");
@@access(Azure.OpenAI.AzureChatExtensionsMessageContext, Access.public, "java");
@@access(Azure.OpenAI.ChatCompletions, Access.public, "java");
@@access(Azure.OpenAI.FunctionDefinition, Access.public, "java");
@@access(Azure.OpenAI.FunctionName, Access.public, "java");
@@access(Azure.OpenAI.ImageSize, Access.public, "java");

(@include would be equivalent)

draft PR on OpenAI Azure/azure-sdk-for-java#36642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsp, enhance handling of access = internal (model and operation)
1 participant