-
Notifications
You must be signed in to change notification settings - Fork 83
tsp, internal model generate to implementation package #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsp, internal model generate to implementation package #2293
Conversation
1b6c089
to
241890a
Compare
219a53f
to
4bd2ba7
Compare
openai need to have change to
@@access(Azure.OpenAI.FunctionName, Access.public, "java");
@@access(Azure.OpenAI.AzureChatExtensionConfiguration, Access.public, "java");
@@access(Azure.OpenAI.AzureChatExtensionsMessageContext, Access.public, "java");
@@access(Azure.OpenAI.ChatCompletions, Access.public, "java");
@@access(Azure.OpenAI.FunctionDefinition, Access.public, "java");
@@access(Azure.OpenAI.ImageSize, Access.public, "java"); result Azure/azure-sdk-for-java#36642 PS: there maybe more to add to Access.public, to help them get synced Also we probably no longer need these "custom-types" configure. It should be covered by API marked as custom-types-subpackage: "implementation.models"
custom-types: "FunctionCallModelBase,FunctionCallPreset,FunctionCallPresetFunctionCallModel,FunctionNameFunctionCallModel" This be delayed to #2300 |
link #2286
main code
SchemaContext.ConvenienceApi
toSchemaContext.Public
model/class would have either
Public
orInternal
(and optionallyExternal
for class from other lib), but not both.API could have
ConvenienceAPI
andInternal
(currently ifInternal
, it is notConvenienceAPI
-- this can change when we decide to generate "package private" Convenience method for Internal).