Improve pen secondary button handling on list box #18766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt(null)` behaves the same as root visual
This reverts commit 2562d73.
maxkatz6
added
bug
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
MrJul
added
the
backport-candidate-11.3.x
|
Will test this once my pen arrives (should be next week) |
kekekeks
reviewed
May 16, 2025
| @@ -64,9 +64,11 @@ protected override void OnPointerPressed(PointerPressedEventArgs e) | |||
| if (p.Properties.PointerUpdateKind is PointerUpdateKind.LeftButtonPressed or | |||
| PointerUpdateKind.RightButtonPressed) | |||
| { | |||
| if (p.Pointer.Type == PointerType.Mouse) | |||
| if (p.Pointer.Type == PointerType.Mouse | |||
| || (p.Pointer.Type == PointerType.Pen && p.Properties.IsRightButtonPressed)) | |||
There was a problem hiding this comment.
Do we need to update the logic in PointerReleased handler here (line 108):
// As we only update selection from touch/pen on pointer release, we need to raise
// the pointer event on the owner to trigger a commit.
if (e.Pointer.Type != PointerType.Mouse)There was a problem hiding this comment.
It's not going to get there, since _pointerDownPoint is unset
kekekeks
approved these changes
May 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MrJul
pushed a commit
that referenced
this pull request
Jun 5, 2025
* Only start ScrollGesture when left click pressed, also `GetCurrentPoint(null)` behaves the same as root visual * Allow right-click pen to select items on press * Add context menus to even items on ListBox page for testing * Avoid global static in UpdateSelectionFromPointerEvent * Revert "Avoid global static in UpdateSelectionFromPointerEvent" This reverts commit 2562d73. * Add comment to UpdateSelectionFromPointerEvent * Use fully mocked rendering for list box test * Add pen selection tests * TouchTestHelper should use correct inputs
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Historically, pen input in Avalonia copies touch input behavior way too much. It makes sense in some areas, like primary button press to scroll. But not so much with secondary/right button press. Touch doesn't have a secondary button at all, but pen should copy mouse behavior there.
Some operations are hard to achieve with pen, now are possible/easier with this PR: dnd with pen (at least in-process), selecting item AND showing context menu on same press+release combo.
This PR makes following changes:
This PR behavior is closer to WPF than UWP though, as UWP doesn't select list item if there is a context menu. But majority of modern windows apps follow WPF logic from my observation (including this PR).
What is the current behavior?
What is the updated/expected behavior with this PR?
* DND related rules are not part of this PR, and not part of Avalonia itself. User applications and third-party controls decide themselves when to call
DragDrop.Do(by filtering pointer props usually in PointerPressed event). I added these columns for the completion.Pending: TreeDataGrid changes for the same rules.
Checklist
Breaking changes
Pen right click has different behavior now.
Obsoletions / Deprecations
Fixed issues
Fixes https://support.avaloniaui.net/agent/tickets/444