Fix creating fields for attached properties called name. closes #12283 #12294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jul 23, 2023
maxkatz6
reviewed
Jul 23, 2023
|
You can test this PR using the following package version. |
|
@maxkatz6 Any idea why integration tests are failing? Seems winappdrive had some connection issues, can these be re-triggered? |
|
@Mrxx99 sometimes they fail for no reason obvious. Merge master to trigger build again. |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This fixes the issue that the Avalonia.Generators is creating fields for attached proerties that have the name "Name"
What is the current behavior?
A field is created for attached properties called "Name", leading to compile errors, if they contain characters not valid for field names like spaces. A common use case for this is the
AutomationProperties.Name. (#12283)What is the updated/expected behavior with this PR?
No field is generated for attached properties with name "Name"
How was the solution implemented (if it's not obvious)?
Filtering out attached properties in XamlNameResolver by checking if
DeclaringTypeis different toTargetType.Checklist
Breaking changes
Technical yes, if users would have relied on a wrongly generated field, but I would say that is rather unlikely and is easily fixable by the user.
Obsoletions / Deprecations
none
Fixed issues
Fixes #12283