Merge pull request #12294 from Mrxx99/fix/attached-property-name-generation

Fix creating fields for attached properties called name. closes #12283

Author: maxkatz6

src/tools/Avalonia.Generators/Common/XamlXNameResolver.cs

@@ -38,6 +38,7 @@ IXamlAstNode IXamlAstVisitor.Visit(IXamlAstNode node)
         {
             if (child is XamlAstXamlPropertyValueNode propertyValueNode &&
                 propertyValueNode.Property is XamlAstNamePropertyReference namedProperty &&
+                !IsAttachedProperty(namedProperty) &&
                 namedProperty.Name == "Name" &&
                 propertyValueNode.Values.Count > 0 &&
                 propertyValueNode.Values[0] is XamlAstTextNode text)
@@ -89,4 +90,9 @@ private string TryGetFieldModifier(XamlAstObjectNode objectNode)
             _ => _defaultFieldModifier
         };
     }
+
+    private static bool IsAttachedProperty(XamlAstNamePropertyReference namedProperty)
+    {
+        return !namedProperty.DeclaringType.Equals(namedProperty.TargetType);
+    }
 }

tests/Avalonia.Generators.Tests/Views/NamedControl.xml

@@ -2,6 +2,7 @@
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
         x:Class="Sample.App.NamedControl">
     <TextBox Name="UserNameTextBox"
+             AutomationProperties.Name="The user name"
              Watermark="Username input"
              UseFloatingWatermark="True" />
-</Window>
+</Window>

tests/Avalonia.Generators.Tests/Views/xNamedControl.xml

@@ -2,6 +2,7 @@
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
         x:Class="Sample.App.xNamedControl">
     <TextBox x:Name="UserNameTextBox"
+             AutomationProperties.Name="The user name"
              Watermark="Username input"
              UseFloatingWatermark="True" />
-</Window>
+</Window>