Call child realize from parent realize. #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were calling r.g. `TreeDataGridCellsPresenter.UpdateRowIndex` from `TreeDataGridRow.Realize` instead of `TreeDataGridCellsPresenter.Realize`. This was causing the cells presenter to be stuck in a half-realized state. Make sure we call child `Realize` on realize and parent `UpdateRowIndex` only when updating row index. Added checks to ensure that `UpdateRowIndex` can't be called on an unrealized row or cell. Fixes #218
|
Customer confirms this fixes the issue. Going to merge because I'm still unable to create a unit test :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were calling e.g.
TreeDataGridCellsPresenter.UpdateRowIndexfromTreeDataGridRow.Realizeinstead ofTreeDataGridCellsPresenter.Realize. This was causing the cells presenter to be stuck in a half-realized state. Make sure we call childRealizeon realize and parentUpdateRowIndexonly when updating row index. Added checks to ensure thatUpdateRowIndexcan't be called on an unrealized row or cell.I'm still unclear as to why this shows up only when switching tabs (on the sample app) and I've been unable to create a failing unit test for it so far, hence marking it as draft.
Fixes #218