Skip to content

Rows arranged incorrectly after switching tabs #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grokys opened this issue Sep 26, 2023 · 0 comments · Fixed by #219
Closed

Rows arranged incorrectly after switching tabs #218

grokys opened this issue Sep 26, 2023 · 0 comments · Fixed by #219

Comments

@grokys
Copy link
Member

grokys commented Sep 26, 2023

Reported by @danipen:

  • Open the samples app.
  • Select the “Files” tab.
  • Expand some nodes so you have some scroll.
  • Go to the “Drag/Drop” tab.
  • Expand some nodes so you have some scroll.
  • Go back to the “Files” tab.
  • Scroll up/down. The rows get somehow broken. You can notice it because the alternating row color gets broken (there are several contiguous nodes that are in the same background color).
Screen.Recording.2023-09-25.at.17.16.27.mov
grokys added a commit that referenced this issue Sep 27, 2023
@grokys
Call child realize from parent realize.
fdd1475 
Previously we were calling r.g. `TreeDataGridCellsPresenter.UpdateRowIndex` from `TreeDataGridRow.Realize` instead of `TreeDataGridCellsPresenter.Realize`. This was causing the cells presenter to be stuck in a half-realized state. Make sure we call child `Realize` on realize and parent `UpdateRowIndex` only when updating row index. Added checks to ensure that `UpdateRowIndex`  can't be called on an unrealized row or cell.

Fixes #218
@grokys grokys mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call child realize from parent realize. AvaloniaUI/Avalonia.Controls.TreeDataGrid
1 participant
@grokys