Prevent tracks for firing on launchpad step under certain conditions #102311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!--
Link a related issue to this PR. If the PR does not immediately resolve the issue,
for example, it requires a separate deployment to production, avoid
using the "fixes" keyword and instead attach the [Status] Fix Inbound label to
the linked issue.
-->
Closes #101706
Proposed Changes
This PR fixes the issue where events are being recorded for
fullscreen launchpad
even though we are not showing that launchpad. This happens because we fist navigate to theLaunchpad
step before deciding if we should navigate to/home
to show the focused launchpad. We have to update multiple flows as launchpad is not apart of the onboarding flow however the onboarding flow hand off to other flows after site setup is completed.useTracksEventProps
to prevent events from firing whenshouldShowLaunchpadFirst
and we are on the launchpad step. This works as we are immediately redirected to home and so events are not registered.Why are these changes being made?
Testing Instructions
/setup/onboarding
and go through the flowimg
and filter bycalypso_signup_step_start
calypso_signup_step_start
withstep=launchpad
should not be fired.Non onboarding test
/start/free
and go through the flowimg
and filter bycalypso_signup_step_start
calypso_signup_step_start
withstep=launchpad
is firedNetwork tab

Pre-merge Checklist