Skip to content

Prevent tracks for firing on launchpad step under certain conditions #102311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

vykes-mac
Copy link
Contributor

!--
Link a related issue to this PR. If the PR does not immediately resolve the issue,
for example, it requires a separate deployment to production, avoid
using the "fixes" keyword and instead attach the [Status] Fix Inbound label to
the linked issue.
-->

Closes #101706

Proposed Changes

This PR fixes the issue where events are being recorded for fullscreen launchpad even though we are not showing that launchpad. This happens because we fist navigate to the Launchpad step before deciding if we should navigate to /home to show the focused launchpad. We have to update multiple flows as launchpad is not apart of the onboarding flow however the onboarding flow hand off to other flows after site setup is completed.

  • use useTracksEventProps to prevent events from firing when shouldShowLaunchpadFirst and we are on the launchpad step. This works as we are immediately redirected to home and so events are not registered.

Why are these changes being made?

  • To prevent tracks from being recorded incorrectly.

Testing Instructions

  • Go to /setup/onboarding and go through the flow
  • In network tab chose img and filter by calypso_signup_step_start
  • After going through the flow the focused launchpad should be shown in my home and event calypso_signup_step_start with step=launchpad should not be fired.

Non onboarding test

  • Go to /start/free and go through the flow
  • In network tab chose img and filter by calypso_signup_step_start
  • Verify you see the fullscreen launchpad
  • Verify calypso_signup_step_start with step=launchpad is fired

Network tab
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Apr 2, 2025

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/launcpad-step-event-should-not-be-firing on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1094 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
write-flow               +688 B  (+8.8%)     +237 B  (+8.0%)
update-design-flow       +688 B  (+2.2%)     +212 B  (+2.0%)
start-writing-flow       +688 B  (+6.4%)     +226 B  (+6.1%)
newsletter-flow          +688 B  (+7.2%)     +230 B  (+6.9%)
build-flow               +624 B  (+7.0%)     +189 B  (+5.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vykes-mac vykes-mac merged commit 4fdef56 into trunk Apr 2, 2025
14 checks passed
@vykes-mac vykes-mac deleted the fix/launcpad-step-event-should-not-be-firing branch April 2, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen LP events erroneously firing
2 participants