Prevent launchpad track events from firing when focused launchpad to be shown #102023

vykes-mac · 2025-03-28T01:08:23Z

Proposed Changes

This PR fixes the issue where events are being recorded for fullscreen launchpad even though we are not showing that launchpad. This happens because we fist navigate to the Launchpad step before deciding if we should navigate to /home to show the focused launchpad. We have to update multiple flows as launchpad is not apart of the onboarding flow however the onboarding flow hand off to other flows after site setup is completed.

use useTracksEventProps to prevent events from firing when shouldShowLaunchpadFirst and we are on the launchpad step. This works as we are immediately redirected to home and so events are not registered.

Why are these changes being made?

To prevent tracks from being recorded incorrectly.

Testing Instructions

Go to /setup/onboarding and go through the flow
In network tab chose img and filter by calypso_signup_step_start
After going through the flow the focused launchpad should be shown in my home and event calypso_signup_step_start with step=launchpad should not be fired.

Non onboarding test

Go to /start/free and go through the flow
In network tab chose img and filter by calypso_signup_step_start
Verify you see the fullscreen launchpad
Verify calypso_signup_step_start with step=launchpad is fired

Network tab

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

- Introduced `useSite` and `getStepFromURL` hooks to manage site and step state. - Implemented conditional logic in `useTracksEventProps` across multiple flows to prevent tracking events from firing when the launchpad is active. - Ensured consistent handling of loading states for tracking events in the `build`, `newsletter`, `start-writing`, `update-design`, and `write` flows.

github-actions · 2025-03-28T01:08:34Z

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

matticbot · 2025-03-28T01:12:44Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~25828 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-login              -129262 B  (-5.7%)   -40167 B  (-6.0%)
entry-main               -121465 B  (-5.2%)   -41524 B  (-6.6%)
entry-stepper              +6096 B  (+0.5%)    +2392 B  (+0.6%)
entry-subscriptions        +4604 B  (+0.3%)    +2428 B  (+0.5%)
entry-domains-landing      +3008 B  (+0.4%)    +1209 B  (+0.6%)
entry-browsehappy            +52 B  (+0.0%)     +379 B  (+0.6%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1100 bytes removed 📉 [gzipped])

name                                parsed_size            gzip_size
reader                                +151488 B   (+4.2%)   +46689 B   (+4.8%)
plugins                               +139696 B   (+4.3%)   +43058 B   (+4.9%)
domains                               +138854 B   (+5.2%)   +40162 B   (+5.7%)
patterns                              +137582 B   (+7.0%)   +40677 B   (+7.2%)
a8c-for-agencies-plugins              +135666 B   (+6.5%)   +41696 B   (+7.2%)
jetpack-cloud-plugin-management       +135479 B   (+5.8%)   +41641 B   (+6.5%)
a8c-for-agencies-sites                +134987 B   (+6.4%)   +38479 B   (+6.8%)
plans                                 +134216 B   (+6.3%)   +41922 B   (+6.9%)
site-logs                             +134000 B  (+11.1%)   +38553 B  (+11.6%)
github-deployments                    +133922 B  (+10.8%)   +38553 B  (+11.0%)
staging-site                          +133805 B  (+10.1%)   +38800 B  (+10.5%)
site-monitoring                       +133738 B  (+11.0%)   +38450 B  (+11.0%)
site-purchases                        +133731 B   (+6.0%)   +38438 B   (+6.5%)
sites-dashboard                       +133349 B  (+12.0%)   +38463 B  (+12.4%)
subscribers                           +132969 B  (+11.6%)   +39524 B  (+12.6%)
a8c-for-agencies-referrals            +132377 B  (+13.6%)   +37326 B  (+14.1%)
a8c-for-agencies-woopayments          +132334 B  (+15.1%)   +37274 B  (+15.9%)
a8c-for-agencies-team                 +132267 B  (+14.9%)   +37111 B  (+15.6%)
site-performance                      +132263 B   (+9.3%)   +38177 B   (+9.3%)
purchases                             +132242 B   (+5.2%)   +40345 B   (+5.8%)
a8c-for-agencies-migrations           +132235 B  (+14.6%)   +37220 B  (+15.3%)
hosting                               +131673 B   (+8.5%)   +38029 B   (+8.7%)
a8c-for-agencies-client               +131649 B  (+10.8%)   +37077 B  (+11.1%)
site-settings                         +131494 B   (+9.1%)   +37719 B   (+9.3%)
a8c-for-agencies-overview             +128847 B  (+11.2%)   +36615 B  (+11.8%)
a8c-for-agencies-marketplace          +124523 B  (+14.5%)   +38980 B  (+15.2%)
overview                              +123773 B   (+4.9%)   +35730 B   (+5.3%)
media                                  +65474 B   (+4.4%)   +21316 B   (+5.1%)
account                                +63531 B   (+8.7%)   +20342 B   (+9.2%)
add-ons                                +60934 B  (+16.8%)   +20266 B  (+17.6%)
jetpack-app                            +60463 B  (+15.1%)   +20390 B  (+16.2%)
settings                               +60146 B   (+6.1%)   +19937 B   (+6.9%)
themes                                 +50158 B   (+5.5%)   +17821 B   (+6.5%)
theme                                  +41510 B   (+5.7%)   +14814 B   (+6.6%)
earn                                   +38489 B   (+4.8%)   +13460 B   (+5.6%)
a8c-for-agencies-partner-directory     +31147 B   (+6.4%)   +11057 B   (+7.1%)
home                                   +31042 B   (+1.8%)    +9563 B   (+1.9%)
stats                                  +29065 B   (+2.5%)    +8618 B   (+2.6%)
jetpack-cloud-settings                 +28442 B   (+4.0%)    +9678 B   (+4.9%)
settings-performance                   +28163 B   (+5.7%)    +8777 B   (+5.8%)
email                                  +27769 B   (+3.0%)   +10915 B   (+4.0%)
notification-settings                  -24062 B   (-3.3%)    -4227 B   (-2.0%)
gutenberg-editor                       +21786 B   (+4.0%)    +7400 B   (+4.4%)
import                                 +20041 B   (+2.8%)    +7084 B   (+3.2%)
signup                                 +18281 B   (+6.9%)    +2600 B   (+4.3%)
marketing                              +18162 B   (+2.2%)    +5138 B   (+2.1%)
jetpack-cloud-partner-portal           +13860 B   (+1.4%)    +4913 B   (+1.7%)
async-step-unified-plans               +13727 B   (+1.5%)    +2401 B   (+0.9%)
a8c-for-agencies-signup                +11401 B   (+5.4%)    +4559 B   (+7.2%)
developer                              +10964 B   (+1.9%)    +3635 B   (+2.1%)
privacy                                +10920 B   (+1.9%)    +3615 B   (+2.1%)
security                               +10868 B   (+1.3%)    +3251 B   (+1.4%)
switch-site                            +10846 B   (+5.8%)    +4483 B   (+8.4%)
account-close                          +10670 B   (+1.8%)    +2946 B   (+1.7%)
site-blocks                            +10602 B   (+1.8%)    +2828 B   (+1.6%)
async-step-unified-domains             +10530 B   (+0.9%)     +770 B   (+0.2%)
jetpack-cloud-agency-signup            +10469 B  (+14.4%)    +3923 B  (+16.6%)
help                                   +10460 B   (+1.8%)    +2843 B   (+1.6%)
me                                     +10358 B   (+1.9%)    +2805 B   (+1.7%)
backup                                  +9836 B   (+0.8%)    +2312 B   (+0.7%)
jetpack-cloud-agency-dashboard          +9583 B   (+0.9%)    +2817 B   (+0.9%)
settings-podcast                        +9543 B   (+1.9%)    +2868 B   (+1.9%)
jetpack-cloud-overview                  +8811 B   (+2.1%)    +2731 B   (+2.1%)
jetpack-connect                         +8739 B   (+0.8%)    +2327 B   (+0.7%)
settings-security                       +8647 B   (+1.8%)    +2769 B   (+1.9%)
posts-custom                            +8636 B   (+1.3%)    +2332 B   (+1.1%)
posts                                   +8634 B   (+1.3%)    +2333 B   (+1.1%)
marketplace                             +8600 B   (+1.6%)    +2456 B   (+1.4%)
people                                  +8502 B   (+1.0%)    +2636 B   (+1.1%)
jetpack-social                          +8459 B   (+1.3%)    +3199 B   (+1.7%)
settings-jetpack                        +8325 B   (+1.5%)    +2390 B   (+1.5%)
jetpack-cloud                           +8284 B   (+2.2%)    +2858 B   (+2.4%)
a8c-for-agencies-landing                +8203 B   (+5.5%)    +2713 B   (+6.0%)
a8c-for-agencies-agency-tier            +8192 B   (+3.6%)    +2627 B   (+3.7%)
a8c-for-agencies-settings               +8180 B   (+3.9%)    +2621 B   (+4.0%)
settings-writing                        +8133 B   (+1.4%)    +2659 B   (+1.6%)
scan                                    +8071 B   (+0.9%)    +1985 B   (+0.8%)
settings-newsletter                     +8055 B   (+1.5%)    +2427 B   (+1.6%)
activity                                +7826 B   (+1.0%)    +2275 B   (+1.1%)
concierge                               +7665 B   (+1.6%)    +2839 B   (+2.1%)
google-my-business                      +7396 B   (+1.4%)     +472 B   (+0.3%)
settings-discussion                     +7366 B   (+1.9%)    +2458 B   (+2.1%)
pages                                   +7287 B   (+1.6%)    +2052 B   (+1.4%)
migrate                                 +7224 B   (+2.0%)    +1663 B   (+1.5%)
jetpack-cloud-pricing                   +7206 B   (+0.9%)    +1871 B   (+0.8%)
customize                               +7156 B   (+2.4%)    +1808 B   (+1.9%)
performance-profiler                    +7133 B   (+2.0%)    +2451 B   (+2.1%)
comments                                +7130 B   (+0.9%)    +1791 B   (+0.9%)
a8c-for-agencies-purchases              +7121 B   (+0.9%)    +1830 B   (+0.8%)
jetpack-search                          +7052 B   (+1.2%)    +1848 B   (+1.1%)
a8c-for-agencies                        +7048 B   (+6.3%)    +1961 B   (+5.8%)
settings-reading                        +6831 B   (+1.6%)    +2195 B   (+1.8%)
woocommerce-installation                +6732 B   (+2.1%)    +2186 B   (+2.2%)
preview                                 +6667 B   (+2.5%)    +2023 B   (+2.5%)
jetpack-cloud-features-comparison       +6640 B   (+1.0%)    +1752 B   (+0.9%)
export                                  +6568 B   (+2.1%)    +2066 B   (+2.2%)
woocommerce                             +6459 B   (+2.2%)    +1868 B   (+2.1%)
promote-post-i2                         +6215 B   (+0.8%)    +1118 B   (+0.5%)
accept-invite                           +5588 B   (+3.2%)    +1416 B   (+2.8%)
checkout                                +5158 B   (+0.3%)    +2123 B   (+0.4%)
site-profiler                           +3656 B   (+1.3%)    +1733 B   (+2.0%)
devdocs                                 +3064 B   (+1.7%)     +338 B   (+0.6%)
entrepreneur-flow                       +1196 B   (+0.7%)     +939 B   (+1.7%)
stepper-user-step                       -1117 B   (-0.4%)     +914 B   (+1.2%)
newsletter-flow                         +1083 B  (+11.4%)     +376 B  (+11.3%)
async-step-use-my-domain                 -990 B   (-0.2%)     +623 B   (+0.4%)
onboarding-flow                          +937 B   (+0.4%)     +174 B   (+0.2%)
update-design-flow                       +824 B   (+2.7%)     +228 B   (+2.2%)
write-flow                               +758 B   (+9.7%)     +269 B   (+9.1%)
start-writing-flow                       +754 B   (+7.0%)     +264 B   (+7.1%)
build-flow                               +679 B   (+7.6%)     +217 B   (+6.8%)
purchase-product                         +622 B   (+0.3%)     +266 B   (+0.5%)
hosted-site-migration-flow               +534 B   (+1.3%)     +100 B   (+0.8%)
site-migration-flow                      +526 B   (+1.3%)      +95 B   (+0.8%)
readymade-template-flow                  +480 B   (+0.3%)       +9 B   (+0.0%)
site-setup-flow                          +456 B   (+0.1%)      +21 B   (+0.0%)
jetpack-cloud-manage-pricing             +432 B   (+0.1%)     +104 B   (+0.1%)
example-flow                             +413 B   (+1.3%)     +142 B   (+1.3%)
hundred-year-domain                      +399 B   (+0.2%)      +81 B   (+0.1%)
connect-domain                           +338 B   (+0.2%)      +91 B   (+0.2%)
hundred-year-plan                        +313 B   (+0.2%)      +58 B   (+0.1%)
new-hosted-site-flow-user-included       +298 B   (+0.2%)      +54 B   (+0.1%)
wpcom-xhr-request                        +247 B   (+1.2%)      +11 B   (+0.2%)
new-hosted-site-flow                     +149 B   (+0.1%)      +29 B   (+0.1%)
copy-site-flow                            +55 B   (+0.1%)      -17 B   (-0.1%)
lasagnaMiddleware                         +54 B   (+0.2%)       +7 B   (+0.1%)
root                                      +40 B   (+1.7%)       +2 B   (+0.2%)
plugin-bundle-flow                        +25 B   (+0.3%)       +3 B   (+0.1%)
incoming-redirect                         +20 B   (+0.1%)       -5 B   (-0.1%)
hundred-year-domain-transfer              +17 B   (+0.5%)      +10 B   (+0.8%)
google-transfer                           +17 B   (+0.8%)       +4 B   (+0.4%)
update-options-flow                       +13 B   (+0.7%)       +6 B   (+0.7%)
transferring-hosted-site-flow             +13 B   (+0.2%)      +12 B   (+0.6%)
reblogging-flow                           +12 B   (+0.6%)       +8 B   (+0.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~132951 bytes added 📈 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-signup-steps-p2-complete-profile                                         +170254 B     (new)   +54796 B     (new)
async-load-comment-block-editor                                                     +132932 B   (+5.2%)   +40035 B   (+5.9%)
async-load-automattic-global-styles-src-components-global-styles-variations         +108366 B   (+6.0%)   +31095 B   (+6.1%)
async-load-design-wordpress-components-gallery                                       +84980 B  (+11.0%)   +24756 B  (+12.1%)
async-load-design-blocks                                                             +76305 B   (+3.7%)   +26484 B   (+4.6%)
async-load-signup-steps-p2-site                                                      +69279 B     (new)   +22069 B     (new)
async-load-design                                                                    +62667 B   (+4.3%)   +19168 B   (+5.3%)
async-load-design-playground                                                         +62074 B   (+4.7%)   +19068 B   (+5.8%)
async-load-calypso-lib-account-settings-helper                                       +59453 B  (+51.1%)   +19919 B  (+54.7%)
async-load-quick-language-switcher                                                   +58794 B  (+95.0%)   +19775 B  (+94.7%)
async-load-calypso-post-editor-media-modal                                           +58254 B   (+4.7%)   +18944 B   (+5.6%)
async-load-calypso-post-editor-editor-media-modal                                    +50844 B   (+3.8%)   +16076 B   (+4.4%)
async-load-signup-steps-p2-join-workspace                                            +48289 B     (new)   +16495 B     (new)
async-load-automattic-help-center                                                    +43142 B   (+6.7%)   +14617 B   (+7.6%)
async-load-signup-steps-p2-confirm-email                                             +41837 B     (new)   +14631 B     (new)
async-load-calypso-layout-command-palette                                            +10975 B   (+5.0%)    +4530 B   (+7.2%)
async-load-signup-steps-user                                                          +6143 B   (+2.7%)    +1609 B   (+2.2%)
async-load-automattic-whats-new                                                       +5388 B  (+17.8%)    +1862 B  (+18.2%)
async-load-calypso-blocks-jitm-templates-modal                                        +4465 B  (+20.9%)    +1232 B  (+16.6%)
async-load-calypso-components-web-preview-component                                   +3926 B   (+0.9%)     +684 B   (+0.5%)
async-load-automattic-help-center-stepper                                             +3618 B   (+0.4%)     +237 B   (+0.1%)
async-load-signup-steps-domains                                                       -3529 B   (-0.5%)     -275 B   (-0.1%)
async-load-calypso-lib-store-sandbox-helper                                           +2838 B   (+8.7%)    +1402 B  (+15.0%)
async-load-calypso-blocks-editor-checkout-modal                                       -2451 B   (-0.2%)      -89 B   (-0.0%)
async-load-calypso-layout-masterbar-checkout                                          -2213 B   (-3.1%)     -634 B   (-2.4%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...      -2183 B   (-0.6%)     -700 B   (-0.6%)
async-load-purchase-modal-wrapper                                                     -2125 B   (-0.5%)     -733 B   (-0.6%)
async-load-calypso-jetpack-cloud-sections-sidebar-navigation-manage-selected-...      +1464 B   (+1.3%)     +582 B   (+1.5%)
async-load-calypso-my-sites-sidebar                                                   +1457 B   (+5.3%)     +376 B   (+4.2%)
async-load-store-app-store-stats                                                      +1430 B   (+0.5%)     -189 B   (-0.3%)
async-load-calypso-notifications                                                      +1233 B   (+0.6%)     +589 B   (+1.0%)
async-load-calypso-blocks-support-article-dialog-dialog                                +922 B   (+1.0%)     +270 B   (+0.9%)
async-load-store-app-store-stats-listview                                              +893 B   (+0.7%)     +147 B   (+0.4%)
async-load-signup-steps-woocommerce-install-step-store-address                         +757 B   (+0.9%)     +265 B   (+0.9%)
async-load-signup-steps-emails                                                         +717 B   (+0.9%)     +257 B   (+1.0%)
async-load-calypso-blocks-jitm-templates-home-task                                     +683 B   (+1.3%)     +294 B   (+1.6%)
async-load-signup-steps-woocommerce-install-step-business-info                         +671 B   (+0.6%)      +71 B   (+0.2%)
async-load-signup-steps-clone-credentials                                              +656 B   (+0.7%)     +217 B   (+0.8%)
async-load-signup-steps-rewind-form-creds                                              +653 B   (+0.8%)     +209 B   (+0.8%)
async-load-signup-steps-plans-theme-preselected                                        -611 B   (-0.1%)    +1053 B   (+0.7%)
async-load-signup-steps-plans                                                          -611 B   (-0.1%)    +1047 B   (+0.7%)
async-load-signup-steps-design-picker                                                  +606 B   (+0.9%)     +225 B   (+1.0%)
async-load-signup-steps-site-picker                                                    +605 B   (+0.3%)     +326 B   (+0.4%)
async-load-signup-steps-site-options                                                   +605 B   (+1.2%)     +229 B   (+1.3%)
async-load-signup-steps-difm-site-picker                                               +605 B   (+0.3%)     +332 B   (+0.4%)
async-load-signup-steps-clone-destination                                              +601 B   (+1.3%)     +211 B   (+1.3%)
async-load-signup-steps-social-profiles                                                +593 B   (+1.4%)     +212 B   (+1.5%)
async-load-signup-steps-site                                                           +569 B   (+1.0%)     +188 B   (+1.0%)
async-load-calypso-reader-sidebar                                                      -558 B   (-0.6%)     -146 B   (-0.6%)
async-load-signup-steps-creds-confirm                                                  +531 B   (+0.8%)     +193 B   (+0.9%)
async-load-signup-steps-creds-permission                                               +527 B   (+0.7%)     +187 B   (+0.8%)
async-load-signup-steps-clone-ready                                                    +517 B   (+0.8%)     +191 B   (+0.9%)
async-load-signup-steps-woocommerce-install-transfer                                   +508 B   (+1.0%)     +190 B   (+1.1%)
async-load-signup-steps-hosting-decider                                                +499 B   (+1.3%)     +187 B   (+1.4%)
async-load-signup-steps-rewind-were-backing                                            +491 B   (+1.3%)     +179 B   (+1.4%)
async-load-signup-steps-clone-start                                                    +491 B   (+1.2%)     +183 B   (+1.2%)
async-load-signup-steps-clone-cloning                                                  +491 B   (+1.2%)     +187 B   (+1.3%)
async-load-signup-steps-woocommerce-install-confirm                                    +478 B   (+0.7%)     +187 B   (+0.8%)
async-load-signup-steps-new-or-existing-site                                           +448 B   (+0.7%)      -38 B   (-0.2%)
async-load-calypso-reader-discover-discover-stream                                     -438 B   (-3.4%)     -148 B   (-3.3%)
async-load-calypso-blocks-product-purchase-features-list                               +420 B   (+0.9%)      +32 B   (+0.3%)
async-load-signup-steps-site-or-domain                                                 +413 B   (+0.9%)     +167 B   (+1.1%)
async-load-calypso-blocks-calendar-popover                                             -412 B   (-0.2%)     -779 B   (-1.4%)
async-load-signup-steps-intent                                                         +398 B   (+0.8%)     +173 B   (+1.0%)
async-load-signup-steps-starting-point                                                 +392 B   (+0.8%)     +161 B   (+1.0%)
async-load-automattic-design-preview                                                   -374 B   (-0.9%)      -49 B   (-0.4%)
async-load-signup-steps-store-features                                                 +369 B   (+0.7%)     +151 B   (+0.8%)
async-load-signup-steps-courses                                                        +367 B   (+0.3%)     +179 B   (+0.5%)
async-load-calypso-my-sites-stats-pages-subscribers                                    +349 B   (+0.2%)     +122 B   (+0.2%)
async-load-calypso-my-sites-site-settings-seo-settings-form                            +329 B   (+0.1%)      -35 B   (-0.0%)
async-load-signup-steps-website-content                                                +319 B   (+0.2%)     +167 B   (+0.3%)
async-load-signup-steps-page-picker                                                    +290 B   (+0.1%)      -80 B   (-0.1%)
async-load-calypso-blocks-app-banner                                                   +287 B   (+0.2%)      +96 B   (+0.2%)
async-load-calypso-components-sites-add-new-site-content                               -285 B   (-5.0%)      -80 B   (-4.1%)
async-load-calypso-layout-guided-tours-component                                       +260 B   (+0.5%)      +83 B   (+0.6%)
async-load-calypso-components-jetpack-portal-nav                                       +260 B   (+0.5%)      +93 B   (+0.7%)
async-load-calypso-my-sites-current-site-notice                                        +236 B   (+0.4%)     +108 B   (+0.5%)
async-load-calypso-layout-community-translator                                         +210 B   (+0.7%)      +68 B   (+0.8%)
async-load-masterbar-cart-masterbar-cart-wrapper                                       -204 B   (-0.2%)      +21 B   (+0.1%)
async-load-signup-steps-website-content-section-types                                  +159 B   (+0.1%)     +129 B   (+0.3%)
async-load-calypso-blocks-jitm                                                         -144 B   (-0.2%)      -19 B   (-0.1%)
async-load-calypso-lib-network-connection                                              +138 B   (+3.4%)      +67 B   (+4.4%)
async-load-calypso-signup-step-wrapper                                                 +105 B   (+0.6%)      +21 B   (+0.3%)
async-load-calypso-my-sites-stats-pages-purchase                                       +103 B   (+0.2%)      +51 B   (+0.3%)
async-load-calypso-my-sites-stats-jetpack-upsell-section                                +95 B   (+0.7%)      +32 B   (+0.7%)
async-load-calypso-my-sites-current-site-domain-warnings                                +94 B   (+0.3%)      +18 B   (+0.2%)
async-load-calypso-reader-site-subscriptions-manager-pending-subscriptions-ma...        +93 B   (+0.2%)      +39 B   (+0.2%)
async-load-calypso-reader-site-subscriptions-manager-comment-subscriptions-ma...        +93 B   (+0.2%)      +39 B   (+0.2%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                                 +89 B   (+0.2%)      +76 B   (+0.4%)
async-load-calypso-blocks-jitm-templates-notice                                         +89 B   (+0.2%)      +72 B   (+0.4%)
async-load-calypso-blocks-jitm-templates-default                                        +89 B   (+0.2%)      +77 B   (+0.4%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                        +85 B   (+0.4%)      +24 B   (+0.4%)
async-load-twemoji                                                                      +80 B   (+0.7%)      +62 B   (+1.8%)
async-load-calypso-reader-search-stream                                                 +80 B   (+0.1%)      +34 B   (+0.2%)
async-load-calypso-lib-analytics-signup                                                 +79 B   (+0.6%)      +15 B   (+0.3%)
async-load-masterbar-help-center                                                        +78 B   (+1.0%)       +6 B   (+0.2%)
async-load-calypso-blocks-cookie-banner                                                 +75 B   (+0.4%)      +31 B   (+0.4%)
async-load-automattic-search                                                            +70 B   (+0.3%)      +41 B   (+0.5%)
async-load-calypso-my-sites-stats-summary                                               +66 B   (+0.1%)      +26 B   (+0.2%)
async-load-calypso-blocks-login-two-factor-authentication-two-factor-content            +45 B   (+0.2%)       +8 B   (+0.1%)
async-load-calypso-my-sites-stats-pages-realtime-chart                                  +43 B   (+0.0%)     +230 B   (+0.3%)
async-load-calypso-reader-p-2-main                                                      +42 B   (+1.1%)      +14 B   (+1.0%)
async-load-calypso-reader-a-8-c-main                                                    +42 B   (+1.1%)      +13 B   (+0.9%)
async-load-calypso-my-sites-stats-comment-follows                                       +42 B   (+0.2%)      +12 B   (+0.2%)
async-load-calypso-my-sites-stats-pages-insights                                        +39 B   (+0.1%)      +44 B   (+0.3%)
async-load-calypso-reader-site-subscription                                             +36 B   (+0.2%)      +12 B   (+0.2%)
async-load-signup-steps-clone-point                                                     -35 B   (-0.0%)      +41 B   (+0.1%)
async-load-calypso-my-sites-stats-stats-post-detail                                     +30 B   (+0.1%)       -1 B   (-0.0%)
async-load-calypso-layout-guided-tours                                                  +29 B   (+0.4%)      +11 B   (+0.5%)
async-load-calypso-blocks-reader-full-post                                              +29 B   (+0.1%)       +7 B   (+0.1%)
async-load-calypso-my-sites-stats-wordads                                               +25 B   (+0.1%)       +8 B   (+0.1%)
async-load-calypso-my-sites-stats-components-line-chart                                 +25 B   (+0.0%)     +220 B   (+0.2%)
async-load-signup-steps-woocommerce-install-hooks-use-site-settings                     +23 B   (+0.3%)       -9 B   (-0.3%)
async-load-calypso-lib-analytics-track-resurrections                                    +18 B   (+1.6%)       +6 B   (+1.1%)
async-load-migration-success                                                            +17 B   (+0.2%)      +14 B   (+0.4%)
async-load-emoji-text                                                                   +12 B   (+0.0%)       -3 B   (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Moment.js Locales (~115 bytes removed 📉 [gzipped])

name                    parsed_size            gzip_size
moment-locale-x-pseudo       +307 B  (+19.9%)       -2 B  (-0.2%)
moment-locale-is             +159 B   (+7.6%)       +2 B  (+0.2%)
moment-locale-bn-bd          -115 B   (-4.1%)      -12 B  (-1.1%)
moment-locale-hu             +107 B   (+5.2%)       +1 B  (+0.1%)
moment-locale-ku-kmr          +85 B   (+4.2%)       +0 B
moment-locale-tzl             +82 B   (+4.9%)       +1 B  (+0.1%)
moment-locale-ga              +75 B   (+5.5%)       -3 B  (-0.4%)
moment-locale-mk              -71 B   (-3.8%)      -10 B  (-1.1%)
moment-locale-bg              -71 B   (-3.9%)      -11 B  (-1.2%)
moment-locale-ta              -68 B   (-2.2%)      -14 B  (-1.2%)
moment-locale-tk              +67 B   (+4.4%)       +2 B  (+0.3%)
moment-locale-cs              +61 B   (+2.0%)      +13 B  (+1.0%)
moment-locale-vi              +59 B   (+3.7%)       +6 B  (+0.8%)
moment-locale-sq              +59 B   (+4.5%)      -10 B  (-1.4%)
moment-locale-fo              +57 B   (+4.7%)       -1 B  (-0.2%)
moment-locale-sk              +51 B   (+2.3%)       +2 B  (+0.2%)
moment-locale-et              +51 B   (+3.4%)       +0 B
moment-locale-zh-tw           -50 B   (-2.8%)       -9 B  (-1.0%)
moment-locale-zh-mo           -50 B   (-2.8%)       -9 B  (-1.0%)
moment-locale-zh-hk           -50 B   (-2.8%)      -11 B  (-1.2%)
moment-locale-zh-cn           -50 B   (-2.6%)       -8 B  (-0.8%)
moment-locale-ug-cn           -50 B   (-2.1%)       -7 B  (-0.7%)
moment-locale-tr              +49 B   (+2.9%)      +11 B  (+1.2%)
moment-locale-pt-br           +49 B   (+3.6%)       -5 B  (-0.7%)
moment-locale-az              +47 B   (+2.6%)      +10 B  (+1.1%)
moment-locale-pt              +43 B   (+3.2%)       -6 B  (-0.8%)
moment-locale-ru              -41 B   (-0.9%)      -12 B  (-0.7%)
moment-locale-se              +39 B   (+2.9%)       -2 B  (-0.3%)
moment-locale-gl              +39 B   (+2.6%)       -3 B  (-0.4%)
moment-locale-gd              +39 B   (+2.8%)       -2 B  (-0.3%)
moment-locale-sv              +35 B   (+2.7%)       -3 B  (-0.4%)
moment-locale-fi              +32 B   (+1.6%)      -11 B  (-1.2%)
moment-locale-oc-lnc          +29 B   (+1.8%)       +4 B  (+0.5%)
moment-locale-nb              +29 B   (+2.3%)       -1 B  (-0.1%)
moment-locale-da              +25 B   (+2.1%)       -1 B  (-0.2%)
moment-locale-tlh             -23 B   (-1.1%)      -11 B  (-1.2%)
moment-locale-nl              +23 B   (+1.1%)       -1 B  (-0.1%)
moment-locale-es-mx           +23 B   (+1.0%)       +1 B  (+0.1%)
moment-locale-es              +23 B   (+1.0%)       +0 B
moment-locale-fr-ch           +21 B   (+1.5%)       -2 B  (-0.3%)
moment-locale-fr-ca           +21 B   (+1.5%)       -1 B  (-0.1%)
moment-locale-fr              +21 B   (+1.0%)      +12 B  (+1.3%)
moment-locale-es-us           +21 B   (+0.9%)       +1 B  (+0.1%)
moment-locale-es-do           +21 B   (+0.9%)       +0 B
moment-locale-nn              +19 B   (+1.5%)       -1 B  (-0.1%)
moment-locale-nl-be           +19 B   (+0.9%)       -1 B  (-0.1%)
moment-locale-lb              +18 B   (+1.0%)      -12 B  (-1.2%)
moment-locale-ro              +15 B   (+1.2%)       -3 B  (-0.4%)
moment-locale-it-ch           +11 B   (+0.8%)       +1 B  (+0.1%)
moment-locale-it              +11 B   (+0.7%)       +0 B
moment-locale-ca              +11 B   (+0.6%)       +3 B  (+0.3%)

Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot · 2025-03-28T01:24:15Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/launcpad-step-event-firing on your sandbox.

paulopmt1

This PR works as described, but I wonder what are the advantages of persuing this strategy instead of the previous one where we were preventing them to go to full screen launchpad at all.

That seems an approach more aligned with the end goal of removing the full screen launchpad entirely.

Should we fix the blog onboarding bug and revert our revert as an ideal solution?

vykes-mac · 2025-03-31T19:26:52Z

This PR works as described, but I wonder what are the advantages of persuing this strategy instead of the previous one where we were preventing them to go to full screen launchpad at all.

That seems an approach more aligned with the end goal of removing the full screen launchpad entirely.

Should we fix the blog onboarding bug and revert our revert as an ideal solution?

There are other areas that navigates to fullscreen launchpad separate from the blog onboarding that will require a fuller scale cleanup. This approach is more of a fill in the gap until we can do the full scale clean up.

autumnfjeld · 2025-04-01T00:35:23Z

If we go with the quick fix, then can you make an issue for the follow up work? With detailed info on the approach to take @vykes-mac ?

Then we'll make that issue part of Launchpad Cleanup, which I assume is in our near future as part of work described in pet6gk-27S-p2

This reverts commit ef12a66, reversing changes made to 7c01746.

vykes-mac · 2025-04-02T01:16:49Z

This PR commits have gotten messed up closing

vykes-mac · 2025-04-02T01:35:37Z

closed in favor of #102311

vykes-mac self-assigned this Mar 28, 2025

vykes-mac added the Needs Multiple Reviews label Mar 28, 2025

vykes-mac requested a review from alshakero March 28, 2025 01:09

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 28, 2025

vykes-mac requested review from paulopmt1 and p-jackson March 28, 2025 01:09

paulopmt1 reviewed Mar 31, 2025

View reviewed changes

vykes-mac added 2 commits April 1, 2025 20:06

Merge branch 'trunk' into fix/launcpad-step-event-firing

ef12a66

Revert "Merge branch 'trunk' into fix/launcpad-step-event-firing"

9af83c3

This reverts commit ef12a66, reversing changes made to 7c01746.

vykes-mac requested review from a team as code owners April 2, 2025 01:14

vykes-mac requested a review from jeyip April 2, 2025 01:14

vykes-mac closed this Apr 2, 2025

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 2, 2025

vykes-mac deleted the fix/launcpad-step-event-firing branch April 2, 2025 01:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prevent launchpad track events from firing when focused launchpad to be shown #102023

Prevent launchpad track events from firing when focused launchpad to be shown #102023

Uh oh!

vykes-mac commented Mar 28, 2025

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited by matticbot

Loading

Uh oh!

matticbot commented Mar 28, 2025 •

edited

Loading

Uh oh!

matticbot commented Mar 28, 2025

Uh oh!

paulopmt1 left a comment

Uh oh!

vykes-mac commented Mar 31, 2025

Uh oh!

autumnfjeld commented Apr 1, 2025 •

edited

Loading

Uh oh!

vykes-mac commented Apr 2, 2025

Uh oh!

vykes-mac commented Apr 2, 2025

Uh oh!

Uh oh!

Prevent launchpad track events from firing when focused launchpad to be shown #102023

Prevent launchpad track events from firing when focused launchpad to be shown #102023

Uh oh!

Conversation

vykes-mac commented Mar 28, 2025

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

Uh oh!

github-actions bot commented Mar 28, 2025 • edited by matticbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matticbot commented Mar 28, 2025

Uh oh!

paulopmt1 left a comment

Choose a reason for hiding this comment

Uh oh!

vykes-mac commented Mar 31, 2025

Uh oh!

autumnfjeld commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vykes-mac commented Apr 2, 2025

Uh oh!

vykes-mac commented Apr 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 28, 2025 •

edited by matticbot

Loading

matticbot commented Mar 28, 2025 •

edited

Loading

autumnfjeld commented Apr 1, 2025 •

edited

Loading