AP_SLCANIface: prevent hardfault on arm #30059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #30055 |
tridge
force-pushed
the
pr/fix-slcan-hardfault
branch
from
c01313a to
e70134a
Compare
|
@robertlong13 seems like a reasonable approach, thanks! |
tridge
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
_portto nullptr always carries a risk, as we may be interrupting a thread that was about to dereference it. Once we set_port, we could avoid setting it to nullptr again, and instead use a flag. This allows us to prevent a hardfault without needing a mutex (and this can be a pretty hot path, so it's probably best to avoid it).