Skip to content

Add AC_POLYFENCE_CIRCLE_INT_SUPPORT_ENABLED gates #30048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peterbarker
Copy link
Contributor

@peterbarker peterbarker commented May 12, 2025

We've added code which magically converts things stored in this format into floats (#29526) - actually by removing code which kept fences compatible between an old version of ArduPilot and an even older version of ArduPilot.

We have a timeline for removing this integer-circle code:

+// ArduPilot 4.7 no longer stores circle radiuses that look like
+//   integers as integer item types, so any time a fence is saved the
+//   use of the deprecated types is fixed.
+// ArduPilot 4.8 warns if it loads an integer item, warns user to re-upload the fence
+// ArduPilot 4.9 warns if it loads an integer item, warns user to re-upload the fence
+// ArduPilot 4.10 removes support for them

... We've done 4.7, we don't have the warning for 4.8. But at least we can find this code easily after this.

This is a no-compiler-output change.

Setting the define to 0 saves ~150 bytes on CubeOrange

@peterbarker peterbarker force-pushed the pr/polyfence-gates branch from a5cb880 to ea0d8f8 Compare May 13, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant