Copter: correct setting of deadzone on RC tuning channel #30038
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/run-tuning-dz
branch
from
46b460d to
d835886
Compare
reboot is now required. Also verify that we are zeroing the DZ
peterbarker
force-pushed
the
pr/run-tuning-dz
branch
from
6a70d3b to
75f8386
Compare
peterbarker
force-pushed
the
pr/run-tuning-dz
branch
from
75f8386 to
d58d599
Compare
rmackay9
reviewed
May 12, 2025
rmackay9
reviewed
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lost this when moving from fixed-CH_6 to RC_OPTION=219 in https://github.com/ArduPilot/ardupilot/pull/25203/files
Without this the channel may have a deadzone, meaning the tuning knob won't be entirely linear across its range. From a user perspectiv they might push the value up and up, then find it doesn't move for a while... and then move a lot. Impatient users might blast past the deadzone when nothing is happening...
Behavioural change here: making a channel transmitter-tuning now requires a reboot for it to take effect. This is so we set the deadzone in just one place. Live-resetting the DZ on any channel you set to 219 seems like it could be unfortunate, and Copter doesn't update channel except on reboot (unlike Plane and Rover)