Skip to content

:RC_Channel:add Lowheiser metadata to aux functions #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hwurzburg
Copy link
Collaborator

omitted in original scripting PR

@Hwurzburg Hwurzburg requested a review from Georacer May 8, 2025 13:51
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message needs some help

@@ -211,6 +211,7 @@ const AP_Param::GroupInfo RC_Channel::var_info[] = {
// @Values{Plane}: 108:QRTL Mode
// @Values{Copter}: 109:use Custom Controller
// @Values{Copter, Rover, Plane, Blimp, Sub}: 110:KillIMU3
// @Values{Copter, Rover, Plane, Blimp, Sub}: 111:Loweheiser starter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sub and Blimp seem awfully unlikely :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, but there should be compilation guards added in that case, correct?this reflects current code capabilities

@Hwurzburg
Copy link
Collaborator Author

what commit message would you like to see?

@peterbarker
Copy link
Contributor

what commit message would you like to see?

Same one but without the leading colon.

One of the big disappointments in the github interface - not able to suggest correct commit messages!

@Hwurzburg
Copy link
Collaborator Author

fixed...my dyslexia strikes again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants