-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Disallow setting of readonly/internal parameters via mavftp #29988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peterbarker
wants to merge
5
commits into
ArduPilot:master
Choose a base branch
from
peterbarker:pr/param-write-mavftp-reuse
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Disallow setting of readonly/internal parameters via mavftp #29988
peterbarker
wants to merge
5
commits into
ArduPilot:master
from
peterbarker:pr/param-write-mavftp-reuse
+104
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
May 6, 2025
b75038e
to
e15c638
Compare
e15c638
to
5bdfef5
Compare
5bdfef5
to
122c3fa
Compare
tridge
approved these changes
May 8, 2025
rmackay9
previously requested changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I hate to be annoying but I'd just like to be sure the small requested comment fix goes in before merging
Comments re-added. |
122c3fa
to
322eb62
Compare
322eb62
to
b572d75
Compare
b572d75
to
b73ad13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29985
This work sponsored by Freespace Solutions