Skip to content

AP_AHRS: External wind extimate handler for EKF3 #29973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

suraqis
Copy link

@suraqis suraqis commented May 4, 2025

AP_AHRS: External wind extimate handler for EKF3

Added MAV_CMD_EXTERNAL_WIND_ESTIMATE message handler similar to
MAV_CMD_EXTERNAL_POSITION_ESTIMATE with replay logging and
lua binding

@rmackay9
Copy link
Contributor

rmackay9 commented May 4, 2025

Hi @suraqis,

Thanks for this, one small thing is that all our commits are normally prefixed with the directory name to make backporting easier. So for example, "External wind estimate for EKF3" should be, "AP_NavEKF3: External wind estimate for EKF3"

Also each commit should only affect a single subsystem or directory. It looks like, "External wind estimate for EKF3" includes Lua bindings changes so those should be moved out of the commit

Finally, it would be good to rebase on master to get rid of the "Merge branch .." commit

thanks again!

@peterbarker
Copy link
Contributor

We have this PR already for this which contains Paul's code: #28279

@suraqis
Copy link
Author

suraqis commented May 5, 2025

We have this PR already for this which contains Paul's code: #28279

And unfortunately, I found a lost commit in my PR with DAL changes, so I'd better close my PR?

Any chances to have it in 4.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants